Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: printUrls doesn't have any effect when htmlPlugin is disabled #3731

Closed
ainursharaev opened this issue Oct 15, 2024 · 2 comments · Fixed by #3737
Closed

[Bug]: printUrls doesn't have any effect when htmlPlugin is disabled #3731

ainursharaev opened this issue Oct 15, 2024 · 2 comments · Fixed by #3737
Assignees
Labels
🐞 bug Something isn't working

Comments

@ainursharaev
Copy link

Version

System:
OS: macOS 15.0.1
CPU: (10) arm64 Apple M1 Pro
Memory: 3.47 GB / 32.00 GB
Shell: 5.9 - /bin/zsh
Browsers:
Brave Browser: 126.1.67.123
Chrome: 129.0.6668.101
Firefox: 131.0.2
Safari: 18.0.1
npmPackages:
@rsbuild/core: ^1.0.14 => 1.0.14
@rsbuild/plugin-node-polyfill: ^1.0.4 => 1.0.4,
@rsbuild/plugin-react: ^1.0.4 => 1.0.4
@rsbuild/plugin-sass: ^1.0.3 => 1.0.3
@rsbuild/plugin-svgr: ^1.0.4 => 1.0.4

Details

Hi there! I think one fix applied on printServerURLs broke one use case that I have – I don't output any HTML files as well, because the assets are just served from php server, but I still want to somehow print the nice urls in the console. Before it was possible, but now because of the additional routes check this functionality is not usable in my case. Perhaps you could advice how to do url printing in other way?

Reproduce link

Reproduce Steps

  1. set htmlPlugin to false
  2. see that urls logs are not output, even with custom function in printUrls
@ainursharaev ainursharaev added the 🐞 bug Something isn't working label Oct 15, 2024
@ainursharaev ainursharaev changed the title [Bug]: printUrls doesn't have any effect if htmlPlugin is disabled [Bug]: printUrls doesn't have any effect when htmlPlugin is disabled Oct 15, 2024
@chenjiahan
Copy link
Member

If htmlPlugin is false, Rsbuild will not generate HTML files, so the server urls will not be accessible.

When using the printUrls custom function, I think the URL can be printed, I will fix this in the next release.

@ainursharaev
Copy link
Author

That was fast, @chenjiahan! Thanks a lot ❤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants