Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: support banner.css in bundle: false #265

Open
SoonIter opened this issue Oct 10, 2024 · 1 comment
Open

[Feature]: support banner.css in bundle: false #265

SoonIter opened this issue Oct 10, 2024 · 1 comment

Comments

@SoonIter
Copy link
Member

          > we should remember to add banner and footer tests about bundleless css.

Currently, we do not support banner.css

this.emitFile in loader is not handled by rspack.BannerPlugin

the files are in the chunks.auxiliaryFiles not chunks.files

https://github.com/webpack/webpack/blob/65bce6826b85a48add3371d76ba16a9933326058/lib/BannerPlugin.js#L105

Maybe we can support it by adjusting bannerPlugin in the future, this is a TODO

Originally posted by @SoonIter in #206 (comment)

@fi3ework
Copy link
Member

fi3ework commented Nov 15, 2024

It could be implement here https://github.com/web-infra-dev/rslib/blob/master/packages/core/src/plugins/EntryChunkPlugin.ts now as an "unnative" workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants