test(native-watcher): revert Windows skip

Author: ScriptedAlchemy

crates/rspack_plugin_mf/src/sharing/consume_shared_plugin.rs

@@ -399,10 +399,9 @@ async fn this_compilation(
 
 #[plugin_hook(CompilationFinishModules for ConsumeSharedPlugin, stage = 10)]
 async fn finish_modules(&self, compilation: &mut Compilation) -> Result<()> {
-  // Add finishModules hook to copy buildMeta/buildInfo from fallback modules before webpack's export analysis
-  // This follows webpack's pattern used by FlagDependencyExportsPlugin and InferAsyncModulesPlugin
-  // We use finishModules with high priority stage to ensure buildMeta is available before other plugins process exports
-  // Based on webpack's Compilation.js: finishModules (line 2833) runs before seal (line 2920)
+  // Add finishModules hook to copy buildMeta/buildInfo from fallback modules *after* webpack's export analysis.
+  // Running earlier caused parity regressions, so we intentionally execute later than plugins like FlagDependencyExportsPlugin,
+  // matching the behaviour in the universe-local implementation. This still happens before seal (see webpack's Compilation.js).
 
   let (consume_updates, missing_fallbacks) = {
     let module_graph = compilation.get_module_graph();

packages/rspack-test-tools/src/case/watch.ts

@@ -294,7 +294,7 @@ export function createWatchStepProcessor(
 		// which will cause the compiler not rebuild when the files change.
 		// The timeout is set to 400ms for windows OS and 100ms for other OS.
 		// TODO: This is a workaround, we can remove it when notify support windows better.
-		const timeout = nativeWatcher && process.platform === "win32" ? 8000 : 100;
+		const timeout = nativeWatcher && process.platform === "win32" ? 400 : 100;
 		await new Promise(resolve => setTimeout(resolve, timeout));
 		copyDiff(path.join(context.getSource(), step), tempDir, false);
 		await task;

tests/rspack-test/NativeWatcher-webpack.test.js

@@ -8,22 +8,14 @@ function v(name) {
 	return path.join(__dirname, `native_watcher ${name}`);
 }
 
-if (process.platform === "win32" && process.env.CI) {
-	describe.skip("NativeWatcher webpack parity (skipped on Windows CI)", () => {
-		it("skipped due to native watcher instability on Windows CI", () => {});
-	});
-} else {
-	describeByWalk(
-		v("(webpack-test)"),
-		(name, src, dist) => {
-			createNativeWatcher(name, src, dist, path.join(tempDir, name));
-		},
-		{
-			source: path.resolve(__dirname, "../webpack-test/watchCases"),
-			dist: path.resolve(
-				__dirname,
-				`./js/native-watcher/webpack-test/watch`
-			)
-		}
-	);
-}
+describeByWalk(
+	v("(webpack-test)"),
+	(name, src, dist) => {
+		createNativeWatcher(name, src, dist, path.join(tempDir, name));
+	},
+	{
+		source: path.resolve(__dirname, "../webpack-test/watchCases"),
+		dist: path.resolve(__dirname, `./js/native-watcher/webpack-test/watch`)
+	}
+);
+

tests/rspack-test/NativeWatcher.test.js

@@ -2,19 +2,13 @@ const path = require("path");
 const { describeByWalk, createNativeWatcher } = require("@rspack/test-tools");
 const tempDir = path.resolve(__dirname, `./js/temp`);
 
-if (process.platform === "win32" && process.env.CI) {
-	describe.skip("NativeWatcher (skipped on Windows CI)", () => {
-		it("skipped due to native watcher instability on Windows CI", () => {});
-	});
-} else {
-	describeByWalk(
-		__filename,
-		(name, src, dist) => {
-			createNativeWatcher(name, src, dist, path.join(tempDir, name));
-		},
-		{
-			source: path.join(__dirname, `./watchCases`),
-			dist: path.resolve(__dirname, `./js/native-watcher/watch`)
-		}
-	);
-}
+describeByWalk(
+	__filename,
+	(name, src, dist) => {
+		createNativeWatcher(name, src, dist, path.join(tempDir, name));
+	},
+	{
+		source: path.join(__dirname, `./watchCases`),
+		dist: path.resolve(__dirname, `./js/native-watcher/watch`)
+	}
+);