perf: name_for_condition for Arc<str>

Author: SyMind

crates/rspack_core/src/compilation/make/graph_updater/repair/factorize.rs

@@ -23,7 +23,7 @@ pub struct FactorizeTask {
   pub original_module_identifier: Option<ModuleIdentifier>,
   pub original_module_source: Option<BoxSource>,
   pub original_module_context: Option<Box<Context>>,
-  pub issuer: Option<Box<str>>,
+  pub issuer: Option<Arc<str>>,
   pub issuer_layer: Option<ModuleLayer>,
   pub dependencies: Vec<BoxDependency>,
   pub resolve_options: Option<Arc<Resolve>>,

crates/rspack_core/src/compilation/make/graph_updater/repair/process_dependencies.rs

@@ -101,7 +101,7 @@ impl Task<TaskContext> for ProcessDependenciesTask {
         original_module_source,
         issuer: module
           .as_normal_module()
-          .and_then(|module| module.name_for_condition()),
+          .and_then(|module| module.name_for_condition().cloned()),
         issuer_layer: module.get_layer().cloned(),
         dependencies,
         resolve_options: module.get_resolve_options(),

crates/rspack_core/src/compilation/make/module_executor/execute.rs

@@ -1,4 +1,8 @@
-use std::{collections::VecDeque, iter::once, sync::atomic::AtomicU32};
+use std::{
+  collections::VecDeque,
+  iter::once,
+  sync::{Arc, atomic::AtomicU32},
+};
 
 use itertools::Itertools;
 use rspack_collections::{DatabaseItem, Identifier, IdentifierSet, UkeySet};
@@ -19,7 +23,7 @@ use crate::{
 pub struct ExecutedRuntimeModule {
   pub identifier: Identifier,
   pub name: String,
-  pub name_for_condition: Option<String>,
+  pub name_for_condition: Option<Arc<str>>,
   pub module_type: ModuleType,
   pub size: f64,
   pub cacheable: bool,
@@ -382,7 +386,7 @@ impl Task<ExecutorTaskContext> for ExecuteTask {
         ExecutedRuntimeModule {
           identifier,
           name: runtime_module.name().to_string(),
-          name_for_condition: runtime_module.name_for_condition().map(|n| n.to_string()),
+          name_for_condition: runtime_module.name_for_condition().cloned(),
           module_type: *runtime_module.module_type(),
           cacheable: !(runtime_module.full_hash() || runtime_module.dependent_hash()),
           size: runtime_module_size

crates/rspack_core/src/concatenated_module.rs

@@ -71,7 +71,7 @@ pub struct ConcatenatedModuleHooks {
 pub struct RootModuleContext {
   pub id: ModuleIdentifier,
   pub readable_identifier: String,
-  pub name_for_condition: Option<Box<str>>,
+  pub name_for_condition: Option<Arc<str>>,
   pub lib_indent: Option<String>,
   pub resolve_options: Option<Arc<Resolve>>,
   pub code_generation_dependencies: Option<Vec<BoxModuleDependency>>,
@@ -1600,8 +1600,8 @@ impl Module for ConcatenatedModule {
     Ok(hasher.digest(&compilation.options.output.hash_digest))
   }
 
-  fn name_for_condition(&self) -> Option<Box<str>> {
-    self.root_module_ctxt.name_for_condition.clone()
+  fn name_for_condition(&self) -> Option<&Arc<str>> {
+    self.root_module_ctxt.name_for_condition.as_ref()
   }
 
   fn lib_ident(&self, _options: LibIdentOptions) -> Option<Cow<'_, str>> {

crates/rspack_core/src/module.rs

@@ -314,7 +314,7 @@ pub trait Module:
   ) -> Result<CodeGenerationResult>;
 
   /// Name matched against bundle-splitting conditions.
-  fn name_for_condition(&self) -> Option<Box<str>> {
+  fn name_for_condition(&self) -> Option<&Arc<str>> {
     // Align with https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/Module.js#L852
     None
   }

crates/rspack_core/src/module_factory.rs

@@ -17,7 +17,7 @@ pub struct ModuleFactoryCreateData {
   pub request: String,
   pub context: Context,
   pub dependencies: Vec<BoxDependency>,
-  pub issuer: Option<Box<str>>,
+  pub issuer: Option<Arc<str>>,
   pub issuer_identifier: Option<ModuleIdentifier>,
   pub issuer_layer: Option<ModuleLayer>,
   pub resolver_factory: Arc<ResolverFactory>,

crates/rspack_core/src/normal_module.rs

@@ -148,6 +148,8 @@ pub struct NormalModule {
   build_info: BuildInfo,
   build_meta: BuildMeta,
   parsed: bool,
+
+  name_for_condition: Arc<str>,
 }
 
 static DEBUG_ID: AtomicUsize = AtomicUsize::new(1);
@@ -185,6 +187,16 @@ impl NormalModule {
   ) -> Self {
     let module_type = module_type.into();
     let id = Self::create_id(&module_type, layer.as_ref(), &request);
+
+    // Align with https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/NormalModule.js#L375
+    let resource = resource_data.resource();
+    let idx = resource.find('?');
+    let name_for_condition = if let Some(idx) = idx {
+      Arc::from(resource[..idx].to_string())
+    } else {
+      Arc::from(resource.to_string())
+    };
+
     Self {
       blocks: Vec::new(),
       dependencies: Vec::new(),
@@ -214,6 +226,8 @@ impl NormalModule {
       build_meta: Default::default(),
       parsed: false,
       source_map_kind: SourceMapKind::empty(),
+
+      name_for_condition,
     }
   }
 
@@ -668,15 +682,8 @@ impl Module for NormalModule {
     Ok(hasher.digest(&compilation.options.output.hash_digest))
   }
 
-  fn name_for_condition(&self) -> Option<Box<str>> {
-    // Align with https://github.com/webpack/webpack/blob/8241da7f1e75c5581ba535d127fa66aeb9eb2ac8/lib/NormalModule.js#L375
-    let resource = self.resource_data.resource();
-    let idx = resource.find('?');
-    if let Some(idx) = idx {
-      Some(resource[..idx].into())
-    } else {
-      Some(resource.into())
-    }
+  fn name_for_condition(&self) -> Option<&Arc<str>> {
+    Some(&self.name_for_condition)
   }
 
   fn lib_ident(&self, options: LibIdentOptions) -> Option<Cow<'_, str>> {

crates/rspack_core/src/options/externals.rs

@@ -20,7 +20,7 @@ pub enum ExternalItemValue {
 pub type ExternalItemObject = HashMap<String, ExternalItemValue>;
 
 pub struct ContextInfo {
-  pub issuer: String,
+  pub issuer: Arc<str>,
   pub issuer_layer: Option<String>,
 }
 

crates/rspack_core/src/options/module.rs

@@ -972,7 +972,7 @@ pub struct FuncUseCtx {
   pub real_resource: Option<String>,
   pub resource_query: Option<String>,
   pub resource_fragment: Option<String>,
-  pub issuer: Option<Box<str>>,
+  pub issuer: Option<Arc<str>>,
   pub issuer_layer: Option<String>,
 }
 

crates/rspack_ids/src/id_helpers.rs

@@ -68,7 +68,7 @@ pub fn get_short_module_name(module: &BoxModule, context: &str) -> String {
   };
   let name_for_condition = module.name_for_condition();
   if let Some(name_for_condition) = name_for_condition {
-    return avoid_number(&make_paths_relative(context, &name_for_condition)).to_string();
+    return avoid_number(&make_paths_relative(context, name_for_condition)).to_string();
   };
   "".to_string()
 }