Skip to content

Commit a509e75

Browse files
committed
chore: make manifest as false by default
1 parent c96b5bc commit a509e75

File tree

9 files changed

+2
-12
lines changed

9 files changed

+2
-12
lines changed

packages/rspack/src/container/ModuleFederationPlugin.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export class ModuleFederationPlugin {
5454
enhanced: true
5555
}).apply(compiler);
5656

57-
if (this._options.manifest !== false) {
57+
if (this._options.manifest) {
5858
const manifestOptions: ModuleFederationManifestPluginOptions =
5959
this._options.manifest === true ? {} : { ...this._options.manifest };
6060
const containerName = manifestOptions.name ?? this._options.name;

tests/rspack-test/configCases/container-1-5/manifest/rspack.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ module.exports = {
1414
name: "container",
1515
filename: "container.[chunkhash:8].js",
1616
library: { type: "commonjs-module" },
17+
manifest: true,
1718
exposes: {
1819
'./expose-a': {
1920
import: './module.js',

tests/rspack-test/serialCases/container/0-container-full/rspack.config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ module.exports = [
2727
new ModuleFederationPlugin({
2828
library: { type: "commonjs-module" },
2929
filename: "container.js",
30-
manifest: false,
3130
remotes: {
3231
containerA: {
3332
external: "./container.js"
@@ -49,7 +48,6 @@ module.exports = [
4948
new ModuleFederationPlugin({
5049
library: { type: "module" },
5150
filename: "module/container.mjs",
52-
manifest: false,
5351
remotes: {
5452
containerA: {
5553
external: "./container.mjs"

tests/rspack-test/serialCases/container/1-container-full/rspack.config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ module.exports = [
3737
containerA: "../0-container-full/container.js",
3838
containerB: "./container.js"
3939
},
40-
manifest: false,
4140
...commonMF
4241
})
4342
]
@@ -60,7 +59,6 @@ module.exports = [
6059
containerA: "../../0-container-full/module/container.mjs",
6160
containerB: "./container.mjs"
6261
},
63-
manifest: false,
6462
...commonMF
6563
})
6664
],

tests/rspack-test/serialCases/container/2-container-full/rspack.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ module.exports = {
2020
]
2121
},
2222
exposes: ["./Self"],
23-
manifest: false,
2423
shared: {
2524
react: "react",
2625
"old-react": {

tests/rspack-test/serialCases/container/3-container-full/rspack.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ module.exports = {
66
plugins: [
77
new ModuleFederationPlugin({
88
remoteType: "commonjs-module",
9-
manifest: false,
109
remotes: {
1110
containerB: "../1-container-full/container.js"
1211
},

tests/rspack-test/serialCases/container/eager-shared/rspack.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ module.exports = {
1313
remotes: {
1414
service: "../0-eager-shared/container.js"
1515
},
16-
manifest: false,
1716
shared: {
1817
"tiny-emitter": {
1918
eager: true,

tests/rspack-test/serialCases/container/module-federation-with-shareScope/rspack.config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,6 @@ module.exports = [
3434
name: "container",
3535
library: { type: "commonjs-module" },
3636
filename: "container.js",
37-
manifest: false,
3837
remotes: {
3938
containerA: "../0-container-full/container.js",
4039
containerB: "./container.js"
@@ -61,7 +60,6 @@ module.exports = [
6160
containerA: "../../0-container-full/module/container.mjs",
6261
containerB: "./container.mjs"
6362
},
64-
manifest: false,
6563
...commonMF
6664
})
6765
],

tests/rspack-test/serialCases/container/module-federation/rspack.config.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ function createConfig() {
1111
filename: "container.js",
1212
library: { type: "system" },
1313
exposes: ["./other", "./self", "./dep"],
14-
manifest: false,
1514
remotes: {
1615
abc: "ABC",
1716
def: "DEF",
@@ -23,7 +22,6 @@ function createConfig() {
2322
name: "container2",
2423
filename: "container2.js",
2524
library: { type: "system" },
26-
manifest: false,
2725
exposes: ["./other", "./self", "./dep"],
2826
remotes: {
2927
abc: "ABC",

0 commit comments

Comments
 (0)