From bed0b1888de7d9fd0ba74360558110e15f0a7cda Mon Sep 17 00:00:00 2001 From: harpsealjs Date: Mon, 30 Sep 2024 17:08:55 +0800 Subject: [PATCH] test: try to fix the randomly failed of @rspack/cli test cases (#8030) --- packages/rspack-cli/tests/build/issue-6359/index.test.ts | 2 ++ packages/rspack-cli/tests/build/issue-6359/rspack.config.js | 3 +-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/rspack-cli/tests/build/issue-6359/index.test.ts b/packages/rspack-cli/tests/build/issue-6359/index.test.ts index 40c437be9b7..98496e8abb6 100644 --- a/packages/rspack-cli/tests/build/issue-6359/index.test.ts +++ b/packages/rspack-cli/tests/build/issue-6359/index.test.ts @@ -10,6 +10,8 @@ it("should not have `process.env.WEBPACK_SERVE` set on build mode", async () => it("should have `process.env.WEBPACK_SERVE` set on serve mode", async () => { await runWatch(__dirname, ["serve"], { killString: /rspack compiled/i }); + // wait 1s to make sure the assets have been generated + await new Promise(resolve => setTimeout(resolve, 1000)); const mainJs = await readFile(resolve(__dirname, "dist/main.js"), "utf-8"); expect(mainJs).toContain("WEBPACK_SERVE=true"); diff --git a/packages/rspack-cli/tests/build/issue-6359/rspack.config.js b/packages/rspack-cli/tests/build/issue-6359/rspack.config.js index 0327f8f30ca..6b413a7131c 100644 --- a/packages/rspack-cli/tests/build/issue-6359/rspack.config.js +++ b/packages/rspack-cli/tests/build/issue-6359/rspack.config.js @@ -1,5 +1,4 @@ const path = require("path"); -const { WEBPACK_SERVE } = process.env; module.exports = /** @type {import('@rspack/cli').Configuration} */ { mode: "production", entry: "./entry.js", @@ -12,7 +11,7 @@ module.exports = /** @type {import('@rspack/cli').Configuration} */ { apply(compiler) { new compiler.webpack.DefinePlugin({ DEFINE_ME: JSON.stringify( - `WEBPACK_SERVE=${WEBPACK_SERVE ?? ""}` + `WEBPACK_SERVE=${process.env.WEBPACK_SERVE ?? ""}` ) }).apply(compiler); }