You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When using dev server and HMR I noticed the following:
updating styles for the main components work correctly.
updating styles for components lazily loaded via import() is left for one iteration.
Example:
change the background color from blue to red, save the file.
HMR is triggered, judging by the console.
Expected result: background is red
Actual result: the background still blue.
now change the background color from red to yellow, save the file.
HMR is triggered, judging by the console.
Expected result: background is yellow
Actual result: background turned red
I tried to reproduce the minimal repl and the problem seems to appear when using [fullhash] or [contenthash] in the output.filename / output.chunkFilename.
(although at some point the styles of the main components stopped updating completely)
dartess
changed the title
[Bug]: live reload of styles is broken when using hashes in names
[Bug]: live reload of styles lazy components is broken when using hashes in names
Jun 20, 2024
This issue has been automatically marked as stale because it has not had recent activity. If this issue is still affecting you, please leave any comment (for example, "bump"). We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!
System Info
System:
OS: macOS 14.5
CPU: (10) arm64 Apple M1 Pro
Memory: 6.46 GB / 32.00 GB
Shell: 5.9 - /bin/zsh
Binaries:
Node: 20.12.1 - /usr/local/bin/node
Yarn: 1.22.18 - /usr/local/bin/yarn
npm: 10.5.0 - /usr/local/bin/npm
pnpm: 8.4.0 - ~/Library/pnpm/pnpm
bun: 1.0.28 - ~/.bun/bin/bun
Browsers:
Brave Browser: 126.1.67.116
Chrome: 126.0.6478.62
Chrome Canary: 128.0.6544.0
Edge: 111.0.1661.54
Safari: 17.5
Safari Technology Preview: 17.4
npmPackages:
@rspack/cli: ^0.7.4 => 0.7.4
@rspack/core: ^0.7.4 => 0.7.4
@rspack/plugin-react-refresh: ^0.7.4 => 0.7.4
Details
When using dev server and HMR I noticed the following:
updating styles for the main components work correctly.
updating styles for components lazily loaded via
import()
is left for one iteration.Example:
blue
tored
, save the file.Expected result: background is
red
Actual result: the background still
blue
.red
toyellow
, save the file.Expected result: background is
yellow
Actual result: background turned
red
I tried to reproduce the minimal repl and the problem seems to appear when using
[fullhash]
or[contenthash]
in theoutput.filename
/output.chunkFilename
.(although at some point the styles of the main components stopped updating completely)
Reproduce link
https://github.com/dartess/rspack-hmr-bug
Reproduce Steps
npm run dev
src/Page/Page.module.css
with some another colorcolor#1
Expected result: background is
color#1
Actual result: the background still
indianred
.src/Page/Page.module.css
with some another colorcolor#2
Expected result: background is
color#2
Actual result: the background turned
color#1
.The text was updated successfully, but these errors were encountered: