Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): integrate rspack_resolver with input_filesystem #7858

Merged
merged 7 commits into from
Sep 22, 2024

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Sep 11, 2024

Summary

Caution

since the performance regression is not acceptable for inputFilesystem binding, won't export input filesystem to js side now

related to #7478
This PR support input_filesystem api in rust side and bridge with resolver's filesystem: this will not introduce performance regression

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Sep 11, 2024
Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bb14f92
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/66eec43d73d1dd0008c1595f

@hardfist hardfist force-pushed the yj/support_input_filesystem branch 2 times, most recently from 69a509b to 592a787 Compare September 14, 2024 13:07
@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 14, 2024

📝 Benchmark detail: Open

Name Base (2024-09-14 0325a3d) Current Change
10000_development-mode + exec 2.21 s ± 28 ms 2.45 s ± 21 ms +10.66 %
10000_development-mode_hmr + exec 692 ms ± 21 ms 701 ms ± 7.8 ms +1.29 %
10000_production-mode + exec 2.83 s ± 40 ms 3.02 s ± 50 ms +6.37 %
arco-pro_development-mode + exec 1.81 s ± 84 ms 2.19 s ± 102 ms +20.72 %
arco-pro_development-mode_hmr + exec 434 ms ± 3.8 ms 442 ms ± 1.7 ms +1.69 %
arco-pro_production-mode + exec 3.25 s ± 78 ms 3.59 s ± 40 ms +10.47 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.29 s ± 75 ms 3.64 s ± 90 ms +10.74 %
threejs_development-mode_10x + exec 1.68 s ± 20 ms 1.69 s ± 33 ms +0.58 %
threejs_development-mode_10x_hmr + exec 780 ms ± 13 ms 795 ms ± 9.9 ms +1.94 %
threejs_production-mode_10x + exec 5.17 s ± 16 ms 5.2 s ± 34 ms +0.56 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","arco-pro_production-mode_generate-package-json-webpack-plugin + exec"]

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 14, 2024

📝 Benchmark detail: Open

Name Base (2024-09-14 0325a3d) Current Change
10000_development-mode + exec 2.21 s ± 28 ms 2.45 s ± 28 ms +10.49 %
10000_development-mode_hmr + exec 692 ms ± 21 ms 692 ms ± 9.4 ms +0.09 %
10000_production-mode + exec 2.83 s ± 40 ms 3 s ± 14 ms +5.65 %
arco-pro_development-mode + exec 1.81 s ± 84 ms 2.19 s ± 70 ms +20.46 %
arco-pro_development-mode_hmr + exec 434 ms ± 3.8 ms 442 ms ± 1.3 ms +1.69 %
arco-pro_production-mode + exec 3.25 s ± 78 ms 3.58 s ± 49 ms +10.04 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.29 s ± 75 ms 3.66 s ± 70 ms +11.13 %
threejs_development-mode_10x + exec 1.68 s ± 20 ms 1.7 s ± 29 ms +1.15 %
threejs_development-mode_10x_hmr + exec 780 ms ± 13 ms 801 ms ± 3.9 ms +2.69 %
threejs_production-mode_10x + exec 5.17 s ± 16 ms 5.18 s ± 60 ms +0.30 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","arco-pro_production-mode_generate-package-json-webpack-plugin + exec"]

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 15, 2024

📝 Benchmark detail: Open

Name Base (2024-09-15 8d5717c) Current Change
10000_development-mode + exec 2.21 s ± 25 ms 2.62 s ± 24 ms +18.65 %
10000_development-mode_hmr + exec 690 ms ± 13 ms 677 ms ± 10 ms -1.84 %
10000_production-mode + exec 2.83 s ± 42 ms 3.11 s ± 16 ms +10.05 %
arco-pro_development-mode + exec 1.81 s ± 82 ms 2.25 s ± 57 ms +24.31 %
arco-pro_development-mode_hmr + exec 432 ms ± 3.1 ms 441 ms ± 3.3 ms +2.08 %
arco-pro_production-mode + exec 3.22 s ± 71 ms 3.67 s ± 109 ms +14.01 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.28 s ± 51 ms 3.74 s ± 88 ms +14.18 %
threejs_development-mode_10x + exec 1.67 s ± 15 ms 1.73 s ± 22 ms +3.55 %
threejs_development-mode_10x_hmr + exec 775 ms ± 21 ms 805 ms ± 17 ms +3.81 %
threejs_production-mode_10x + exec 5.14 s ± 39 ms 5.22 s ± 32 ms +1.60 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","arco-pro_production-mode_generate-package-json-webpack-plugin + exec"]

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 17, 2024

📝 Benchmark detail: Open

Name Base (2024-09-17 6f17ffa) Current Change
10000_development-mode + exec 2.22 s ± 26 ms 2.6 s ± 24 ms +16.98 %
10000_development-mode_hmr + exec 686 ms ± 12 ms 694 ms ± 5.7 ms +1.24 %
10000_production-mode + exec 2.82 s ± 24 ms 3.19 s ± 22 ms +13.12 %
arco-pro_development-mode + exec 1.83 s ± 65 ms 2.31 s ± 28 ms +26.02 %
arco-pro_development-mode_hmr + exec 432 ms ± 2.2 ms 444 ms ± 4 ms +2.66 %
arco-pro_production-mode + exec 3.22 s ± 98 ms 3.71 s ± 73 ms +15.20 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.32 s ± 44 ms 3.78 s ± 68 ms +14.04 %
threejs_development-mode_10x + exec 1.67 s ± 16 ms 1.76 s ± 27 ms +5.18 %
threejs_development-mode_10x_hmr + exec 781 ms ± 6.5 ms 803 ms ± 9.1 ms +2.77 %
threejs_production-mode_10x + exec 5.17 s ± 39 ms 5.21 s ± 48 ms +0.92 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","arco-pro_production-mode_generate-package-json-webpack-plugin + exec","threejs_development-mode_10x + exec"]

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 17, 2024

📝 Benchmark detail: Open

Name Base (2024-09-17 6f17ffa) Current Change
10000_development-mode + exec 2.22 s ± 26 ms 3.09 s ± 44 ms +38.99 %
10000_development-mode_hmr + exec 686 ms ± 12 ms 696 ms ± 11 ms +1.46 %
10000_production-mode + exec 2.82 s ± 24 ms 3.69 s ± 65 ms +30.88 %
arco-pro_development-mode + exec 1.83 s ± 65 ms 2.47 s ± 59 ms +35.04 %
arco-pro_development-mode_hmr + exec 432 ms ± 2.2 ms 447 ms ± 1.6 ms +3.41 %
arco-pro_production-mode + exec 3.22 s ± 98 ms 3.88 s ± 47 ms +20.33 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.32 s ± 44 ms 3.93 s ± 67 ms +18.54 %
threejs_development-mode_10x + exec 1.67 s ± 16 ms 1.8 s ± 34 ms +7.75 %
threejs_development-mode_10x_hmr + exec 781 ms ± 6.5 ms 808 ms ± 4.2 ms +3.37 %
threejs_production-mode_10x + exec 5.17 s ± 39 ms 5.27 s ± 35 ms +2.02 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","arco-pro_production-mode_generate-package-json-webpack-plugin + exec","threejs_development-mode_10x + exec"]

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 18, 2024

📝 Benchmark detail: Open

Name Base (2024-09-18 6f17ffa) Current Change
10000_development-mode + exec 2.21 s ± 26 ms 2.64 s ± 26 ms +19.44 %
10000_development-mode_hmr + exec 688 ms ± 16 ms 685 ms ± 8.8 ms -0.42 %
10000_production-mode + exec 2.83 s ± 40 ms 3.11 s ± 30 ms +9.90 %
arco-pro_development-mode + exec 1.82 s ± 69 ms 2.23 s ± 55 ms +22.81 %
arco-pro_development-mode_hmr + exec 433 ms ± 0.93 ms 442 ms ± 3.3 ms +2.15 %
arco-pro_production-mode + exec 3.25 s ± 66 ms 3.63 s ± 77 ms +11.98 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.31 s ± 93 ms 3.66 s ± 57 ms +10.61 %
threejs_development-mode_10x + exec 1.67 s ± 24 ms 1.71 s ± 26 ms +2.42 %
threejs_development-mode_10x_hmr + exec 781 ms ± 8.3 ms 803 ms ± 8.6 ms +2.91 %
threejs_production-mode_10x + exec 5.15 s ± 20 ms 5.2 s ± 20 ms +1.04 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","arco-pro_production-mode_generate-package-json-webpack-plugin + exec"]

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 18, 2024

📝 Benchmark detail: Open

Name Base (2024-09-18 6f17ffa) Current Change
10000_development-mode + exec 2.21 s ± 26 ms 2.34 s ± 68 ms +5.81 %
10000_development-mode_hmr + exec 688 ms ± 16 ms 691 ms ± 10 ms +0.50 %
10000_production-mode + exec 2.83 s ± 40 ms 2.88 s ± 57 ms +1.83 %
arco-pro_development-mode + exec 1.82 s ± 69 ms 1.84 s ± 80 ms +0.93 %
arco-pro_development-mode_hmr + exec 433 ms ± 0.93 ms 433 ms ± 3.3 ms +0.15 %
arco-pro_production-mode + exec 3.25 s ± 66 ms 3.23 s ± 55 ms -0.60 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.31 s ± 93 ms 3.26 s ± 63 ms -1.34 %
threejs_development-mode_10x + exec 1.67 s ± 24 ms 1.67 s ± 14 ms -0.20 %
threejs_development-mode_10x_hmr + exec 781 ms ± 8.3 ms 796 ms ± 10 ms +2.00 %
threejs_production-mode_10x + exec 5.15 s ± 20 ms 5.11 s ± 46 ms -0.85 %

Threshold exceeded: ["10000_development-mode + exec"]

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 18, 2024

📝 Benchmark detail: Open

Name Base (2024-09-18 6f17ffa) Current Change
10000_development-mode + exec 2.21 s ± 26 ms 2.3 s ± 44 ms +3.72 %
10000_development-mode_hmr + exec 688 ms ± 16 ms 691 ms ± 8.9 ms +0.56 %
10000_production-mode + exec 2.83 s ± 40 ms 2.88 s ± 46 ms +1.56 %
arco-pro_development-mode + exec 1.82 s ± 69 ms 1.84 s ± 60 ms +1.13 %
arco-pro_development-mode_hmr + exec 433 ms ± 0.93 ms 432 ms ± 2.3 ms -0.07 %
arco-pro_production-mode + exec 3.25 s ± 66 ms 3.27 s ± 118 ms +0.67 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.31 s ± 93 ms 3.29 s ± 107 ms -0.64 %
threejs_development-mode_10x + exec 1.67 s ± 24 ms 1.66 s ± 17 ms -0.50 %
threejs_development-mode_10x_hmr + exec 781 ms ± 8.3 ms 792 ms ± 8.3 ms +1.50 %
threejs_production-mode_10x + exec 5.15 s ± 20 ms 5.13 s ± 17 ms -0.42 %

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 18, 2024

📝 Benchmark detail: Open

Name Base (2024-09-18 6f17ffa) Current Change
10000_development-mode + exec 2.21 s ± 26 ms 2.64 s ± 35 ms +19.10 %
10000_development-mode_hmr + exec 688 ms ± 16 ms 679 ms ± 15 ms -1.21 %
10000_production-mode + exec 2.83 s ± 40 ms 3.12 s ± 26 ms +10.38 %
arco-pro_development-mode + exec 1.82 s ± 69 ms 2.2 s ± 55 ms +20.99 %
arco-pro_development-mode_hmr + exec 433 ms ± 0.93 ms 442 ms ± 2.2 ms +2.10 %
arco-pro_production-mode + exec 3.25 s ± 66 ms 3.6 s ± 84 ms +10.95 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.31 s ± 93 ms 3.68 s ± 54 ms +11.26 %
threejs_development-mode_10x + exec 1.67 s ± 24 ms 1.7 s ± 36 ms +1.98 %
threejs_development-mode_10x_hmr + exec 781 ms ± 8.3 ms 798 ms ± 12 ms +2.27 %
threejs_production-mode_10x + exec 5.15 s ± 20 ms 5.18 s ± 36 ms +0.51 %

Threshold exceeded: ["10000_development-mode + exec","10000_production-mode + exec","arco-pro_development-mode + exec","arco-pro_production-mode + exec","arco-pro_production-mode_generate-package-json-webpack-plugin + exec"]

@hardfist hardfist marked this pull request as ready for review September 19, 2024 15:05
@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

⏳ Triggered benchmark: Open

@hardfist hardfist requested review from h-a-n-a and ahabhgk and removed request for jerrykingxyz September 19, 2024 15:07
@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 20, 2024

📝 Benchmark detail: Open

Name Base (2024-09-20 9b862a7) Current Change
10000_development-mode + exec 2.22 s ± 45 ms 2.31 s ± 63 ms +3.94 %
10000_development-mode_hmr + exec 691 ms ± 18 ms 686 ms ± 12 ms -0.72 %
10000_production-mode + exec 2.84 s ± 47 ms 2.89 s ± 52 ms +1.67 %
arco-pro_development-mode + exec 1.86 s ± 61 ms 1.84 s ± 70 ms -1.07 %
arco-pro_development-mode_hmr + exec 434 ms ± 2.1 ms 433 ms ± 3.1 ms -0.25 %
arco-pro_production-mode + exec 3.26 s ± 57 ms 3.22 s ± 80 ms -1.10 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.3 s ± 87 ms 3.27 s ± 75 ms -0.85 %
threejs_development-mode_10x + exec 1.66 s ± 13 ms 1.66 s ± 14 ms -0.23 %
threejs_development-mode_10x_hmr + exec 792 ms ± 15 ms 779 ms ± 12 ms -1.62 %
threejs_production-mode_10x + exec 5.17 s ± 22 ms 5.15 s ± 34 ms -0.40 %

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 20, 2024

📝 Benchmark detail: Open

Name Base (2024-09-20 9b862a7) Current Change
10000_development-mode + exec 2.22 s ± 45 ms 2.31 s ± 31 ms +4.14 %
10000_development-mode_hmr + exec 691 ms ± 18 ms 689 ms ± 7.1 ms -0.27 %
10000_production-mode + exec 2.84 s ± 47 ms 2.91 s ± 54 ms +2.60 %
arco-pro_development-mode + exec 1.86 s ± 61 ms 1.84 s ± 73 ms -0.94 %
arco-pro_development-mode_hmr + exec 434 ms ± 2.1 ms 432 ms ± 2.6 ms -0.40 %
arco-pro_production-mode + exec 3.26 s ± 57 ms 3.24 s ± 58 ms -0.43 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.3 s ± 87 ms 3.29 s ± 78 ms -0.14 %
threejs_development-mode_10x + exec 1.66 s ± 13 ms 1.66 s ± 11 ms -0.11 %
threejs_development-mode_10x_hmr + exec 792 ms ± 15 ms 785 ms ± 5.6 ms -0.81 %
threejs_production-mode_10x + exec 5.17 s ± 22 ms 5.16 s ± 30 ms -0.24 %

@hardfist
Copy link
Contributor Author

!bench

@rspack-bot
Copy link

rspack-bot commented Sep 21, 2024

📝 Benchmark detail: Open

Name Base (2024-09-21 e58ac85) Current Change
10000_development-mode + exec 2.24 s ± 33 ms 2.24 s ± 44 ms -0.06 %
10000_development-mode_hmr + exec 704 ms ± 5.6 ms 704 ms ± 18 ms +0.07 %
10000_production-mode + exec 2.91 s ± 35 ms 2.91 s ± 32 ms -0.10 %
arco-pro_development-mode + exec 1.84 s ± 64 ms 1.86 s ± 82 ms +0.99 %
arco-pro_development-mode_hmr + exec 437 ms ± 2.3 ms 434 ms ± 5.4 ms -0.64 %
arco-pro_production-mode + exec 3.31 s ± 73 ms 3.3 s ± 66 ms -0.52 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.38 s ± 88 ms 3.35 s ± 96 ms -0.86 %
threejs_development-mode_10x + exec 1.69 s ± 12 ms 1.69 s ± 15 ms +0.02 %
threejs_development-mode_10x_hmr + exec 795 ms ± 16 ms 794 ms ± 7.1 ms -0.22 %
threejs_production-mode_10x + exec 5.26 s ± 29 ms 5.27 s ± 29 ms +0.24 %

@hardfist hardfist merged commit 45a3997 into main Sep 22, 2024
28 checks passed
@hardfist hardfist deleted the yj/support_input_filesystem branch September 22, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants