Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all the rust plugin stage should be changed to f64 #7862

Open
hardfist opened this issue Sep 11, 2024 · 5 comments
Open

all the rust plugin stage should be changed to f64 #7862

hardfist opened this issue Sep 11, 2024 · 5 comments
Assignees
@pawel-twardziak
Labels
good first issue Good for newcomers team The issue/pr is created by the member of Rspack.

Comments

@hardfist
Copy link
Contributor

currently rust plugin stage use i32 which cause it can't accept Infinity and float points in js side, which is not compatible with webpack, so the stage should be changed to f64 to be compatible with webpack
@hardfist hardfist added the good first issue Good for newcomers label Sep 11, 2024
@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Sep 11, 2024
@pawel-twardziak
Copy link

Can I jump on it? Rspack looks so promising :)

@hardfist
Copy link
Contributor Author

thanks in advance，go try it

@hardfist
Copy link
Contributor Author

@pawel-twardziak are you still working on it or met any problems?

@pawel-twardziak
Copy link

pawel-twardziak commented Sep 19, 2024 •
edited
Loading

@hardfist was busy, couldn't even kick it off :( Today and tomorrow I am on my sick leave so I could finally give it a shot. Any rush? I might need some help. But if you need it sooner feel free to haned it over to someone else.

@pawel-twardziak pawel-twardziak mentioned this issue Sep 20, 2024
Open
2 tasks
pawel-twardziak added a commit to pawel-twardziak/rspack that referenced this issue Sep 20, 2024
@pawel-twardziak
fix(plugins): make rust plugin stage compatible with webpack
6fa723a 
Closes web-infra-dev#7862
@pawel-twardziak
Copy link

Hi, @hardfist I've just raised the job - is that all that should get done?

pawel-twardziak added a commit to pawel-twardziak/rspack that referenced this issue Sep 23, 2024
@pawel-twardziak
fix(plugins): make rust plugin stage compatible with webpack
149dd33 
Closes web-infra-dev#7862
pawel-twardziak added a commit to pawel-twardziak/rspack that referenced this issue Sep 24, 2024
@pawel-twardziak
fix(plugins): make rust plugin stage compatible with webpack
4a7f682 
Closes web-infra-dev#7862
pawel-twardziak added a commit to pawel-twardziak/rspack that referenced this issue Sep 24, 2024
@pawel-twardziak
fix(plugins): make rust plugin stage compatible with webpack
d55e2a9 
Closes web-infra-dev#7862
pawel-twardziak added a commit to pawel-twardziak/rspack that referenced this issue Sep 25, 2024
@pawel-twardziak
fix(plugins): make rust plugin stage compatible with webpack
32497ca 
Closes web-infra-dev#7862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pawel-twardziak pawel-twardziak

Labels
good first issue Good for newcomers team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hardfist @pawel-twardziak