docs: addRuntimeModule and runtimeRequirementInTree #7938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
team
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
the
release: document
chenjiahan
reviewed
Sep 24, 2024
Co-authored-by: neverland <[email protected]>
Co-authored-by: neverland <[email protected]>
chenjiahan
approved these changes
Sep 24, 2024
slorber
reviewed
Sep 26, 2024
| super('custom'); | ||
| } | ||
|
|
||
| generate(compilation) { |
There was a problem hiding this comment.
just wondering, is this compilation param a typo?
Webpack types do not have it:
https://github.com/webpack/webpack/blob/main/types.d.ts#L12839
There was a problem hiding this comment.
Yes, you are right. Pass the compilation as param of RuntimeModule.generate is not aligned with webpack. I will fix it in #8000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add docs of
compilation.addRuntimeModuleandcompilation.hooks.runtimeRequirementInTreeChecklist