Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support import.meta.resolve + Node Specific Meta Values #8008

Open
joealden opened this issue Sep 27, 2024 · 0 comments
Open

[Feature]: Support import.meta.resolve + Node Specific Meta Values #8008

joealden opened this issue Sep 27, 2024 · 0 comments
Labels
feat New feature or request pending triage The issue/PR is currently untouched.

Comments

@joealden
Copy link

What problem does this feature solve?

Node recently added support for the following (currently in RC status):

As webpack + rspack already handle import.meta.url, I feel like it wouldn't be too much of a stretch to support these?

Currently in rspack:

  • import.meta.dirname is replaced by /* unsupported import.meta.dirname */ undefined
  • import.meta.filename is replaced by /* unsupported import.meta.filename */ undefined
  • import.meta.resolve is replaced by ({}).resolve

I'm not sure how webpack handles this today, but it might be worth aligning with the webpack team regardless? And even if we can't support these (in the short term or long term), should the built no error/warn if these are encountered?

What does the proposed API of configuration look like?

I guess maybe node.__filename and node.__dirname could impact these (see https://rspack.dev/config/node), or new options could be added (either generic node.filename and node.dirname properties that handle both CJS and ESM, or a new node.import property just for ESM)?

@joealden joealden added feat New feature or request pending triage The issue/PR is currently untouched. labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request pending triage The issue/PR is currently untouched.
Projects
None yet
Development

No branches or pull requests

1 participant