fix: update regex chunk filter logic to allow empty chunk names #8550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
|
The changes in this PR are not entirely correct. In JavaScript, the |
|
Ah, indeed. Didn't notice because I was using to regex to exclude stuff. It would be better to just mention it in the docs then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #8529 by allowing None chunks to pass the Regex like in JS . This would be a breaking change though.
If this is not ok, than the docs should be updated instead.
Checklist