Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove target-within but reserve its ID for future use #2339

Open
ddbeck opened this issue Nov 26, 2024 · 3 comments
Open

Remove target-within but reserve its ID for future use #2339

ddbeck opened this issue Nov 26, 2024 · 3 comments
Labels
feature definition Creating or defining new features or groups of features. major version required This PR requires a minor version semver release (vX+1.0.0)

Comments

@ddbeck
Copy link
Collaborator

ddbeck commented Nov 26, 2024

:target-within has no implementations, but was tracked in BCD. mdn/browser-compat-data#25188 removed it from BCD.

Unless and until :target-within has a real prospect of implementation (e.g., an intent, a bug with associated commits, etc.), then we shouldn't publish this feature. We ought to:

  • withdraw it in the next major release
  • move the feature description to drafts
  • somehow reserve the feature ID (e.g., make sure there's an error if someone tries to make a non-draft that shadows the draft ID)
@ddbeck ddbeck added feature definition Creating or defining new features or groups of features. major version required This PR requires a minor version semver release (vX+1.0.0) labels Nov 26, 2024
@ddbeck
Copy link
Collaborator Author

ddbeck commented Nov 26, 2024

cc: @jamesnw @Elchi3, closing the loop on mdn/browser-compat-data#25188

@jamesnw
Copy link
Collaborator

jamesnw commented Nov 26, 2024

@ddbeck Question for when BCD version 5.6.19 hits- for this and #2341, should we complete points 1 and 2, and make the next release major? Or should we simply remove the BCD keys, keep the features in the next release, and make the major version update later?

@ddbeck
Copy link
Collaborator Author

ddbeck commented Nov 29, 2024

@jamesnw I'm not in a big hurry to do the major release right now (cleaning up things like this is not as pressing as completing the mapping), so I'm not going to go out of my way to open the PRs needed to do the major release work. That said, if someone wants to do that work, I will review the PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features. major version required This PR requires a minor version semver release (vX+1.0.0)
Projects
None yet
Development

No branches or pull requests

2 participants