-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop html/semantics/popovers/popover-top-layer-interactions.html #677
Comments
@nt1m have you debugged which step of the test the timeout happens? Does it happen even if all of the preceding tests are removed? Fullscreen and popover are related through their use of top layer, so I think this case is a bit different from ones where an unrelated feature is used in a test. It would be good at least know what the bug is, to be sure it's a SafariDriver or fullscreen bug, not a popover bug. |
@foolip This subtest tries to open a fullscreen element followed by another one, and it times out trying to open the second one. FWIW, I'm 100% sure it's unrelated to popover, since all the popover tests successfully run before that (the specific failing subtest is the last one, so none of the other ones are blocked by this one). |
This might solve the issue on the WebKit side, but I'm not sure: WebKit/WebKit@f62c0ed Essentially drops the user gesture requirement for entering fullscreen in WebDriver, in favor of the normal transient activation one. I'll have to wait for next STP to come out to check. |
It didn't, I'm still puzzled why this passes in WebKit Test Runner but not SafariDriver... @foolip If you look at the breakdown of the subtests, it's really just the "stack 2 fullscreen elements" subtest failing: https://wpt.fyi/results/html/semantics/popovers/popover-top-layer-interactions.html?label=experimental&label=master&aligned&view=interop&q=label%3Ainterop-2024-popover which is unrelated to popover. |
Test List
https://wpt.fyi/results/html/semantics/popovers/popover-top-layer-interactions.html?label=master&label=experimental&aligned&view=interop&q=label%3Ainterop-2024-popover
Rationale
This seems to be timing out in Safari just because of a fullscreen subtest, which passes in WebKitTestRunner: https://searchfox.org/wubkat/rev/3dea3f050e72b74b587cf5f4943a60c7b5cb5452/LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-interactions-expected.txt#10
This suggests some kind of issue with SafariDriver and fullscreen, which either way are out-of-scope for the popover focus area.
Another option could be splitting out that subtest, though I don't think it's worth the trouble given everything else passes everywhere.
@foolip @jgraham What do you think?
The text was updated successfully, but these errors were encountered: