Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print/crashtests/reload-crash.html is incorrect #46552

Open
atjn opened this issue May 30, 2024 · 0 comments
Open

print/crashtests/reload-crash.html is incorrect #46552

atjn opened this issue May 30, 2024 · 0 comments

Comments

@atjn
Copy link
Contributor

atjn commented May 30, 2024

Problem

The test print/crashtests/reload-crash.html is not correct.

The test assumes that after opening a print dialog, JS execution continues. The printing spec requires that JS execution is paused when a dialog is opened.

Firefox and Safari follows the spec and pauses JS execution. Therefore they fail this test with a TIMEOUT.
Chrome and Edge does not follow the spec, therefore they pass this test.

There are also other issues with the test which are detailed here: https://issues.chromium.org/issues/40280568#comment9

Solution

To make the test work properly, you need to cancel the print dialog, which is not possible on WPT. (* maybe I am wrong about this, I am not a WPT expert)

The test is for a very specific Chrome bug, so maybe it should simply be removed from WPT and instead live in the Chromium source as a custom test? At the very least, it should be marked tentative and/or optional to show that there is an issue with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant