Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Truffle project to 4.x for testing purposes #6011

Closed
mconnelly8 opened this issue Apr 13, 2023 · 3 comments
Closed

Migrate Truffle project to 4.x for testing purposes #6011

mconnelly8 opened this issue Apr 13, 2023 · 3 comments
Assignees
@nikoulai
Labels
4.x 4.0 related

Comments

@mconnelly8
Copy link

No description provided.

@mconnelly8 mconnelly8 added the 4.x 4.0 related label Apr 13, 2023
@nikoulai nikoulai self-assigned this Apr 21, 2023
@nikoulai
Copy link
Contributor

nikoulai commented May 3, 2023 •
edited
Loading

The PR in the truffle repo: trufflesuite/truffle#6013

@nikoulai
Copy link
Contributor

nikoulai commented May 3, 2023 •
edited
Loading

In a couple of instances dom had to be added as a required lib at the package, because the type RequestInit couldn't be found. This solution was proposed here. (Also see this)
IMO users should just get web3js without having to make any changes in their libs and this case should be handled by our side.

@spacesailor24 spacesailor24 mentioned this issue May 4, 2023
Closed
@nikoulai nikoulai mentioned this issue May 8, 2023
Draft
@mconnelly8 mconnelly8 mentioned this issue May 9, 2023
Closed
@jdevcs
Copy link
Contributor

jdevcs commented Jun 1, 2023

This issue was created for older 4.x testing with truffle, and next RC/Full release should be tested and tracked under #6144

@jdevcs jdevcs closed this as completed Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikoulai nikoulai

Labels
4.x 4.0 related
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nikoulai @jdevcs @mconnelly8