Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in subscribe migration guide #7324

Closed
Joro97 opened this issue Oct 13, 2024 · 1 comment · Fixed by #7334
Closed

Typo in subscribe migration guide #7324

Joro97 opened this issue Oct 13, 2024 · 1 comment · Fixed by #7334

Comments

@Joro97
Copy link

Joro97 commented Oct 13, 2024 •
edited
Loading

There is a small typo in the subscribe migration guide. This PR should fix it.

Steps to reproduce the behavior

  1. Open https://docs.web3js.org/guides/web3_upgrade_guide/subscribe_migration_guide/#subscribing-to-events
  2. Read the third bullet under "Differences"
  3. "...you code..." should become "...your code..."

Logs

Typo can be seen highlighted on the image below. "...you code..." should become "...your code..."
image

Environment

Tested on latest Brave + macOS version.
@Joro97 Joro97 mentioned this issue Oct 13, 2024
Closed
15 tasks
@mconnelly8
Copy link

Thanks @Joro97, the team will review the PR.

danforbes added a commit that referenced this issue Oct 17, 2024
@danforbes
Fix Typo
1f71b68 
Closes #7324
Replaces #7325
@danforbes danforbes linked a pull request Oct 17, 2024 that will close this issue
Intermediate dApp Guide #7334
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Joro97 @mconnelly8