Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors are not caught in many places #19

Open
schmod opened this issue Mar 21, 2014 · 0 comments
Open

Errors are not caught in many places #19

schmod opened this issue Mar 21, 2014 · 0 comments

Comments

@schmod
Copy link

schmod commented Mar 21, 2014

Throughout the library, there are several instances of req.onsuccess = req.onerror, which results in promises resolving when they should have been rejected.

Additionally, many methods within the IndexedDB API can potentially raise DOMExceptions, which are not caught at all by angular-indexedDB. These exceptions can be particularly problematic, because they are often raised within then() blocks inside the library (which makes them impossible to catch from the outside).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant