Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bugs on "each" feature #38

Open
ghost opened this issue Aug 20, 2014 · 2 comments
Open

Possible bugs on "each" feature #38

ghost opened this issue Aug 20, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Aug 20, 2014

I believe "each" has some bugs

  1. I get errors like "object is not a function" because of line 449 callback(e.target.result);
  2. No results because of line 446 if(!e.target.result){

Maybe

...
req.onsuccess = req.onerror = function(e) {
    $rootScope.$apply(function(){
        if(!e.target.result){
            d.resolve(e.target.result);
        }
        callback(e.target.result);
    });
};
...

should be something like

..
req.onsuccess = req.onerror = function(e) {
    $rootScope.$apply(function(){
        if(e.target.result){
            d.resolve(e.target.result);
        }
    });
};
...

with my suggestion things seem to work better but I have no idea is it correct.

What I have is something like

Setup:

var store = db.createObjectStore('fooBar', {keyPath: 'fooBarId', autoIncrement:true});
store.createIndex('keyIndex', ['foo','bar'], {unique:false});

Query:

var store = $indexedDB.objectStore('fooBar');

var key = [ fooValue, barValue ];

var query = $indexedDB.queryBuilder()
                .$index('keyIndex')
                .$eq(key)
                .compile();

return store.each(query).then(function(cursor) {
    if (cursor.value) {
        return cursor.value;
    }
});
@ghost
Copy link
Author

ghost commented Aug 25, 2014

Ok now when I look closer, what I posted above is incorrect since I was using example from README but the actual method signature has changed since

@erik-seifert
Copy link

Can you please provide a correct example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant