Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Cleanup Needed (inconsistent semicolon use) #48

Closed
minig0d opened this issue Jan 12, 2021 · 2 comments
Closed

Code Cleanup Needed (inconsistent semicolon use) #48

minig0d opened this issue Jan 12, 2021 · 2 comments

Comments

@minig0d
Copy link

minig0d commented Jan 12, 2021

Code currently gets mangled during compression due to inconsistent semicolon usage. I am aware of ASI and typically code compresses fine with it, however something about the inconsistency seems to breaks the compression.

Suggest running through eslint with "rules": { "semi": ["error", "always"]} enabled to catch the 4 or 5 missing semicolons and ensure stability rather than relying on ASI https://eslint.org/docs/rules/semi)

@Georgegriff
Copy link
Contributor

I'd happily accept a pr to fix this

@minig0d
Copy link
Author

minig0d commented Jan 12, 2021

Can I just be lazy and tell you its lines: 31, 59, 88, 94, 95, 98, 99, 172? :)
It also flags "Expected a conditional expression and instead saw an assignment" (https://eslint.org/docs/rules/no-cond-assign) on line 165, which is valid but discouraged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants