Skip to content
This repository has been archived by the owner on Jan 27, 2021. It is now read-only.

Support a true "full size" option with wysiwyg images #251

Open
mshick opened this issue Mar 29, 2016 · 0 comments
Open

Support a true "full size" option with wysiwyg images #251

mshick opened this issue Mar 29, 2016 · 0 comments

Comments

@mshick
Copy link

mshick commented Mar 29, 2016

The current behavior is misleading, and limiting. In conjunction with the custom redactor, using the "full size" (internally, in code, called resize_full) icon sends a large command. For those who would like to have an image larger than 1200px in their body, they are left modifying the HTML, and those changes will be wiped out each time somebody uses the wysiwyg image editor.

I will be submitting a PR on the webhook-redactor repo for the complimentary functionality, but will be creating a PR here to support a new imageCommand called full which sets the image resize parameter to s=0, effectively using the natural image size.

The change in this project would be backward compatible, and would only change the behavior for builds using a modified redactor, which will send the full command.

@mshick mshick changed the title Support a true "fullsize" option with wysiwyg images Support a true "full size" option with wysiwyg images Mar 29, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant