Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extraneous data in some outputs #709

Closed
coolaj86 opened this issue Oct 25, 2023 · 1 comment
Closed

extraneous data in some outputs #709

coolaj86 opened this issue Oct 25, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@coolaj86
Copy link
Member

coolaj86 commented Oct 25, 2023

I found this on a dev instance:

    {
        "name": "node-v20.8.1-darwin-arm64.tar.gz",
        "version": "20.8.1",
        "lts": false,
        "channel": "stable",
        "date": "2023-10-13",
        "os": "macos",
        "arch": "arm64",
        "ext": "tar.gz",
        "download": "https://nodejs.org/download/release/v20.8.1/node-v20.8.1-darwin-arm64.tar.gz",
        "oses": [
            "aix",
            "linux",
            "macos",
            "windows"
        ],
        "arches": [
            "ppc64",
            "arm64",
            "armv7l",
            "ppc64le",
            "s390x",
            "amd64",
            "x86",
            "armv6l"
        ],
        "formats": [
            "pkg",
            "zip",
            "msi"
        ]
    }

Notice the extra oses, arches, etc.

I think it comes from here:

rel.oses = rels.oses;
rel.arches = rels.arches;
rel.formats = rels.formats;

It may have been meant for the test suite.

This other file looks correct:

all.oses = Object.keys(supported.oses).filter(function (name) {
return maps.oses[name];
});
all.arches = Object.keys(supported.arches).filter(function (name) {
return maps.arches[name];
});
all.formats = Object.keys(supported.formats).filter(function (name) {
return maps.formats[name];
});

@coolaj86 coolaj86 added the enhancement New feature or request label Oct 25, 2023
@coolaj86
Copy link
Member Author

I found the reason for this. I believe it was already fixed in fc36f3e.

If not, #756 will certainly zap it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant