Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of --define-process-env-node-env is undocumented. #4360

Open
junhaoliao opened this issue Dec 26, 2024 · 2 comments · May be fixed by #4361
Open

Removal of --define-process-env-node-env is undocumented. #4360

junhaoliao opened this issue Dec 26, 2024 · 2 comments · May be fixed by #4361
Labels

Comments

@junhaoliao
Copy link

Describe the bug

The --define-process-env-node-env option is still mentioned in the README.md, even though it seems to have been renamed as config-node-env in #4318 . This could lead to confusion among users trying to use the option.

What is the current behavior?

The README.md references the --define-process-env-node-env option, which appears to no longer exist or function as expected.

To Reproduce

Steps to reproduce the behavior:

  1. Refer to the README.md.
  2. Attempt to use the --define-process-env-node-env option as described.
  3. Notice that it does not work and causes confusion due to its removal.

Expected behavior

The README.md should accurately reflect the current state of the webpack-cli options. If --define-process-env-node-env has been removed, it should be documented accordingly, and references to it should be removed or updated.

Screenshots

N/A
Please paste the results of npx webpack-cli info here, and mention other relevant information

Additional context
This issue is about keeping the documentation in sync with the actual functionality of webpack-cli. The outdated mention of --define-process-env-node-env can mislead users.

@junhaoliao junhaoliao added the Bug label Dec 26, 2024
@junhaoliao junhaoliao changed the title Removal of --define-process-env-node-env is undocumented Removal of --define-process-env-node-env is undocumented. Dec 26, 2024
@evenstensberg
Copy link
Member

this is replaced by --env/--node-env

@junhaoliao
Copy link
Author

this is replaced by --env/--node-env

Thank you for pointing that out. I did notice this change after looking through a few Pull Requests, and it did cause some confusion since it wasn't clearly documented in the new major version release notes. Do you consider the proposed changes in #4361 adequately address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants