Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests #4846

Closed
malcolm-kee opened this issue May 5, 2023 · 3 comments
Closed

Refactor tests #4846

malcolm-kee opened this issue May 5, 2023 · 3 comments

Comments

@malcolm-kee
Copy link
Contributor

Bug report

This is to track the bad tests so I will remember to pick this up later.

Right now some tests will hangs when error, because the puppeteer does not cleanup correctly, such as tests in this file: https://github.com/webpack/webpack-dev-server/blob/master/test/e2e/overlay.test.js

We should include some cleanup if the puppeteer is not cleanup due to error.

Actual Behavior

Expected Behavior

How Do We Reproduce?

Please paste the results of npx webpack-cli info here, and mention other relevant information
@alexander-akait
Copy link
Member

Yeah, maybe we can merge it with #2843

@malcolm-kee malcolm-kee mentioned this issue May 6, 2023
Closed
6 tasks
@malcolm-kee
Copy link
Contributor Author

I think #2843 would probably need more time, I remembered I was blocked by something related to websocket few weeks back.

Besides, this refactoring itself is already very big 😅

@alexander-akait
Copy link
Member

Let's close in favor #2843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix e2e tests to cleanup properly malcolm-kee/webpack-dev-server
2 participants
@alexander-akait @malcolm-kee