Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid crc32 calculation #653

Closed
ikreymer opened this issue Jul 25, 2024 · 0 comments
Closed

Remove invalid crc32 calculation #653

ikreymer opened this issue Jul 25, 2024 · 0 comments
Assignees

Comments

@ikreymer
Copy link
Member

Unfortunately, the crc32 calculation that Browsertrix Crawler is doing is invalid, due to:
alexgorbatchev/crc#70
This is an easy fix, however it was added only to support stream zipping in Browsertrix.

The precalculated crc-32 is no longer needed anyway if uktrade/stream-zip#134 is merged (or we continue using our own fork in Browsertrix)

The options are:

  1. Fix the crc-32 calculation
  2. remove it altogether

Leaning towards removal to simplify / remove something that's not needed anymore.

@ikreymer ikreymer self-assigned this Jul 25, 2024
@ikreymer ikreymer changed the title Remove crc32 calculation Remove invalid crc32 calculation Jul 25, 2024
ikreymer added a commit that referenced this issue Jul 27, 2024
@github-project-automation github-project-automation bot moved this from Triage to Done! in Webrecorder Projects Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done!
Development

No branches or pull requests

1 participant