Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify humanized execution time to always show hours, not days #1377

Closed
tw4l opened this issue Nov 15, 2023 · 2 comments · Fixed by #1386
Closed

Modify humanized execution time to always show hours, not days #1377

tw4l opened this issue Nov 15, 2023 · 2 comments · Fixed by #1386
Assignees
@emma-sg
Labels
front end Requires front end dev work

Comments

@tw4l
Copy link
Member

tw4l commented Nov 15, 2023

Follow-up to #1329

If hours > 24 currently, it will display as 1d 9h 1m 2s, whereas we want it to be 33h 1m 2s.
@tw4l tw4l added the front end Requires front end dev work label Nov 15, 2023
@tw4l tw4l moved this from Triage to Ready for Dev in Webrecorder Projects Nov 15, 2023
@tw4l tw4l assigned tw4l and emma-sg and unassigned tw4l Nov 15, 2023
@ikreymer ikreymer moved this from Ready for Dev to Todo in Webrecorder Projects Nov 15, 2023
@tw4l
Copy link
Member Author

tw4l commented Nov 15, 2023

@emma-sg Assigning to you since you worked on the last iteration but feel free to kick it back if you'd like!

@emma-sg emma-sg moved this from Todo to Ready for Dev in Webrecorder Projects Nov 15, 2023
@ikreymer
Copy link
Member

ikreymer commented Nov 16, 2023 •
edited
Loading

The parens as implemented are not always helpful, eg. 40 minutes(40 m). I think we should either remove them or make them only appear when they're showing new info. (A few examples in #1361)

@emma-sg emma-sg linked a pull request Nov 17, 2023 that will close this issue
Move execution time formatting into its own util #1386
Merged
@github-project-automation github-project-automation bot moved this from Ready for Dev to Done! in Webrecorder Projects Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emma-sg emma-sg

Labels
front end Requires front end dev work
Projects
Webrecorder Projects
Status: Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move execution time formatting into its own util webrecorder/browsertrix
3 participants
@ikreymer @emma-sg @tw4l