Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Collections' item counts aren't updated when uploading a WACZ and adding it to collections #2350

Closed
emma-sg opened this issue Jan 29, 2025 · 0 comments · Fixed by #2351
Assignees
Labels
bug Something isn't working

Comments

@emma-sg
Copy link
Member

emma-sg commented Jan 29, 2025

Browsertrix Version

latest

What did you expect to happen? What happened instead?

When uploading a WACZ, there's a field for selecting collections for the item to be added to. This should update the collection's item & page count, but it doesn't.

Reproduction instructions

  1. Create a target collection, if you don't have one already (it's easiest to show this issue with a new collection, though the issue should apply to any collection)
  2. Open the "Upload a WACZ" dialog from the archived item list page
  3. Select a WACZ file, enter a name, and select the target collection from step 1
  4. Upload the file, and wait until complete
  5. Navigate to the collection list. Note that the collection that we just added an item to hasn't had its "Collection Period", "Archived Items", "Total Pages", "Size", or "Last Modified" stats updated.
  6. Navigate to the collection. Note that:
    • The collection hasn't had its "Archived Items", "Total Pages", or "Last Modified" updated
    • If this is a new collection, the replay is hidden
    • The "Archived Items" tab does display uploaded item from earlier

Screenshots / Video

No response

Environment

No response

Additional details

Should probably be a quick fix — I believe UploadOps._create_upload should call CollectionOps.add_crawls_to_collection for each collection specified in the function call.

Thank you @DaleLore for reporting!

@emma-sg emma-sg added the bug Something isn't working label Jan 29, 2025
@tw4l tw4l self-assigned this Jan 30, 2025
@tw4l tw4l moved this from Triage to Implementing in Webrecorder Projects Jan 30, 2025
@ikreymer ikreymer moved this from Implementing to Todo in Webrecorder Projects Jan 30, 2025
@tw4l tw4l moved this from Todo to In Review in Webrecorder Projects Jan 30, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Jan 30, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

2 participants