Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoder does not reset when disabling a simulcast layer #68

Open
graszka22 opened this issue Apr 13, 2023 · 0 comments
Open

Encoder does not reset when disabling a simulcast layer #68

graszka22 opened this issue Apr 13, 2023 · 0 comments

Comments

@graszka22
Copy link
Contributor

To reproduce on iOS:

  • have a video track with simulcast with 3 layers with H264 hardware encoding
  • disable one layer by setting encoding.isActive to false in peer connection
  • start screencast with H264 hardware encoding
  • the H264 encoder will fail to init with Failed to create compression session: -12915 error, this is caused by ios encoders limit exceeded (iOS max encoders limitation issue twilio/twilio-video-ios#17 ) however, we should use just 3 encoders (2 simulcast layers + 1 screencast)
  • this is probably caused by the encoder not being reset. There is a check here:
    // No need to reset when stream is inactive.
    that doesn't reset if layer is only disabled and nothing else changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant