Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge/replace? #4

Closed
pierrejoye opened this issue Feb 14, 2016 · 17 comments
Closed

merge/replace? #4

pierrejoye opened this issue Feb 14, 2016 · 17 comments

Comments

@pierrejoye
Copy link
Collaborator

Hi,

Great work on the port to 7! Thanks :)

Are you interested to merge into the official (but lacking love, blame me) extension?

I would also like to move the repository to the friendsofphp organization to ease additions of more contributors as well as making it more visible.

Let me know if it sounds good, it would be then easier to move this repository to the organization instead of merging or syncing :)

@szabolcsbalogh szabolcsbalogh self-assigned this Feb 16, 2016
@willfitch
Copy link
Contributor

I agree @pierrejoye. I'm in the middle of updating the original Memcached extension, and I'd like an extension that is maintained by a community as well. There are a lot of failed tests and compilation warnings, but the PHP7 API port compiles.

There doesn't seem to be any commits since Nov 2015. @szabolcsbalogh - can you confirm @pierrejoye's question?

@szabolcsbalogh
Copy link
Contributor

hi

i tried again to contact pecl team, but without answer, so...

we can move the repo, and after i make a readme here, that it was moved (because of projects linked it, like Leaseweb/LswMemcacheBundle#53 (comment))

@willfitch
Copy link
Contributor

@szabolcsbalogh - should be able to just make a PR from https://github.com/php/pecl-caching-memcache.

Is that right, @pierrejoye?

@szabolcsbalogh
Copy link
Contributor

@pierrejoye
Copy link
Collaborator Author

@willfitch I prefer to actually move it to friendsofphp and really use github. The PHP org is only a mirror of git.php.net and PRs have to be manually merged along other little annoyances.

@szabolcsbalogh If you could add me as admin for this repo, I can then simply move it to friendsofphp/memcache, quick and without losing anything. And we can continue to maintain it there, using github issues trackers, PRs and co.

What do you think?

@pierrejoye
Copy link
Collaborator Author

Also github will redirect it as far as I remember, or we can create a new repo with only the README afterwards.

@szabolcsbalogh
Copy link
Contributor

@pierrejoye you have been added as admin

@pierrejoye
Copy link
Collaborator Author

@szabolcsbalogh Thanks!

How would you like to proceed and when? :)

@szabolcsbalogh
Copy link
Contributor

you can move it to friendsofphp/memcache as you wrote. Please left me at least collaborator access level after the move. You can move it any time.

@carlwgeorge
Copy link

Is the move to friendsofphp/memcache going to happen at some point? I would like to subscribe to it.

@szabolcsbalogh
Copy link
Contributor

@pierrejoye do you have any info about move?

@Gasol
Copy link

Gasol commented Aug 19, 2016

@pierrejoye Could you please move to friendsofphp/memcache and update link in pecl/memcache site.

@Jan-E
Copy link
Contributor

Jan-E commented Sep 22, 2016

There does not seem any progress on this. Can we fix the PHP 7.1 builds on Windows in the mean time? See #15

@mtibben
Copy link

mtibben commented Mar 7, 2017

Hi, I'd love to see a versioned release of this repo, as this has become the de-facto fork many downstream packagers are using

I'd suggest

Thoughts? @websupport-sk @tomassrnka @szabolcsbalogh

@tomassrnka
Copy link
Member

@mtibben hi, I'm 100% up for it! How can we move it? I've already suggested to move it some time ago. Any ideas please?

@glensc
Copy link
Contributor

glensc commented Nov 13, 2018

looks like ping to @pierrejoye needed

@tomassrnka
Copy link
Member

Hi, I'm closing this one as a duplicate to #42

bof added a commit to bof/pecl-memcache that referenced this issue Feb 13, 2023
In an attempt to provoke the debug build assertion failure I saw, this
is the first attempt at a test case provoking it.

Doesn't work, yet...

Context on the assertion failure:

  websupport-sk#4  0x00007fc675426c46 in __assert_fail () from /lib64/libc.so.6
  websupport-sk#5  0x00007fc670cbcaf3 in zend_gc_delref (p=0x7fc670bbc000) at /opt/php/include/php/Zend/zend_types.h:1209
  websupport-sk#6  0x00007fc670cbcb59 in zval_delref_p (pz=0x7ffe587973a0) at /opt/php/include/php/Zend/zend_types.h:1245
  websupport-sk#7  0x00007fc670cbcc81 in zval_ptr_dtor_nogc (zval_ptr=0x7ffe587973a0) at /opt/php/include/php/Zend/zend_variables.h:34
  websupport-sk#8  0x00007fc670cbdcbc in ps_read_memcache (mod_data=0x7fc674bed980 <ps_globals+96>, key=0x7fc670b81540, val=0x7ffe58797428,
      maxlifetime=3600) at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/memcache/src/memcache_session.c:385
  websupport-sk#9  0x00007fc673cd7ab3 in php_session_initialize ()
      at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/ext/session/session.c:444
  websupport-sk#10 0x00007fc673cdafa3 in php_session_start () at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/ext/session/session.c:1612
  websupport-sk#11 0x00007fc673cded07 in zif_session_start (execute_data=0x7fc670a12d30, return_value=0x7fc670a12d10)
      at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/ext/session/session.c:2533
  websupport-sk#12 0x00007fc673feea58 in ZEND_DO_ICALL_SPEC_RETVAL_USED_HANDLER ()
      at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/Zend/zend_vm_execute.h:1297
  websupport-sk#13 0x00007fc674063f3c in execute_ex (ex=0x7fc670a12930)
      at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/Zend/zend_vm_execute.h:55779
  websupport-sk#14 0x00007fc673f9a4c3 in zend_call_function (fci=0x7ffe58797990, fci_cache=0x7ffe58797970)
      at /srv/dev/yin/phb/build/ourphp-8.1.15-debug/php-src/Zend/zend_execute_API.c:912
  websupport-sk#15 0x00007fc673f9a97d in zend_call_known_function (fn=0x7fc610866500, object=0x0, called_scope=0x0, retval_ptr=0x0,
      param_count=1, params=0x7ffe58797a20, named_params=0x0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants