-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve torrent graph UI #73
Comments
I could help with something but we should first split it in a separete module: #63 |
@roccomuso If you want to send improvements here first, I can publish it a separate module in a few days. |
@feross I'm working on this features. I've noticed also that the choke and unchoke methods need to be completed. Choking acts on the link and not on the node itself right? We could change the line color or something like that? |
I think that API works! I think making the line more transparent when we're choked would be good. |
ok thanks for the tip, I'm on it right now... ;) By the way I'm introducing a new dependency: https://github.com/avoidwork/filesize.js |
@roccomuso We use |
@feross Alright, now using On the top of the lib in the COLORS variable I've defined some properties required to "map" the transfer rate to the line thickness. |
Screenshot? |
@feross As you can see the link gets thicker and thinner, changing every second his transfer rate to:
|
That's nice. Can you send a PR? |
@feross yes sure. Couldn't be first splitted it in a separate module? So that I can write also the API documentation in a README.md. |
Sure, I'll do that now and add you as GitHub collaborator and npm owner. |
@feross thanks, let me know ;) |
Okay, it's published as |
Here's a PR to make |
ok, I think you can merge the PR. I'm gonna push directly on the p2p-graph repo. |
@roccomuso Nice. Please still send PRs to the |
@feross ok cool! I've sent the PR. |
The text was updated successfully, but these errors were encountered: