-
Notifications
You must be signed in to change notification settings - Fork 5
Check duplicates in the MP test file #276
Comments
Duplicates, in the sense of multiple identical rows isn't a problem, but I found some wiki_ids that don't have identical name strings. these are:
Now there is a file at |
@salgo60, I got two lists from Emil yesterday, which have been compiled into the catalog.csv file mentioned above. I assumed these files were up to date. |
@BobBorges I have now opened a PR for your work. Please move the files to corpus/quality_assesment/known_mp instead. I have a README there as well with info. We should store data there that are used for auality control. |
OK. Let me move the catalog.csv file to where it ought to be and update path info in tests/db.py before you merge. |
I think we need to fix the stuff that fails before we merge (main branch tests should always pass). But it is nice to keep the work in a PR so we can see the changes and discuss the code. |
Closed as duplicate of #316 |
In #265 we have identified that there are duplicate entries in the test files. @salgo60 has started to look at this in #265. We need to double-check that these duplicates are correct.
The text was updated successfully, but these errors were encountered: