修复 #23 问题 #24
Open
修复 #23 问题 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenweihu86
requested changes
Jan 8, 2020
| @@ -29,6 +29,12 @@ public Peer(RaftProto.Server server) { | |||
| isCatchUp = false; | |||
| } | |||
|
|
|||
| public RpcClient createClient() { | |||
| return new RpcClient(new Endpoint( | |||
There was a problem hiding this comment.
这个client感觉应该保存在Peer里，两个client名称上区分下，分别是用于raft内部通信client、提供给application去写入的client。
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
当客户端向集群发起写入请求时，会根据 brpc 的负载均衡策略选取一个节点进行写入，如果被选中的节点不是 Leader 节点，而是从节点，就会报 com.baidu.brpc.exceptions.RpcException: serviceInterface must not be set repeatedly, please use another RpcClient 异常，原因是此时从节点需要向 Leader 发起操作，但是拿到的 rpcClient 已经绑定其它服务接口。