Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR: Separate prefixes and shapes in different files #5

Open
thewillyhuman opened this issue Aug 28, 2020 · 0 comments
Open

ADR: Separate prefixes and shapes in different files #5

thewillyhuman opened this issue Aug 28, 2020 · 0 comments

Comments

@thewillyhuman
Copy link
Member

Separate prefixes and shapes in different files

This ADR focuses on choosing an option regarding whether prefixes and shapes are combined in a single file or if they are separated into different files.

Context

An architectural decission that has to be made is if the prefixes are within the same CSV file as the shape expressions. The main gal of separating them is to apply the single resposability principle. That is, each file contains only one piece of the context and therefore we acchieve cleaner files. But with that said if we separate the prefixes from the shapes file then we will not be able to use some features like prefix override.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant