-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Where did INSTALL go? #402
Comments
Good catch. The file itself contains the generic installation information, so there's not much there that is different about flex. That being said, yes, either reference to it should be removed or it should be re-included. I expect this is a result of changing the project to a "foreign" project from automake's point of view. I'll have to dig to see what the options are.
…On Sunday, 4 November 2018, 11:42 am -0800, Nic Hartley ***@***.***> wrote:
From the README (emphasis mine):
>The flex distribution contains the following files which may be of interest:
> * README - This file.
> * NEWS - current version number and list of user-visible changes.
> * **INSTALL - basic installation information.**
`INSTALL` no longer seems to exist -- I downloaded the latest release, `tar xzf`'d it, and in `flex-2.6.4`, there's no file called `INSTALL`. There isn't even a file containing `INSTALL` anywhere in its name. Has the file been renamed? Or is it just gone? Either way, the README should be updated.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#402
--
Will Estes
[email protected]
|
So what is the solution? |
for the record, I was able to install using the (completely non-obvious) instructions from this stackoverflow answer. |
Note that in addition to INSTALL, the readme file announces the presence of an ABOUT-NLS file with "description of internationalization support in flex". |
the ABOUT-NLS file is included in the flex distribution. (For the record, it's the standard GNU gettext created file). |
In terms of how to build flex:
If all you need is a binary of flex to let you build your application, consult your operating system's package manager or other software installation tooling. Likewise if you need the c++ header FlexLexer.h or the library libfl. |
Running I had some install issues
installed m4 using sudo apt install m4 $ make Am now waaaay out of my comfort zone. |
The m4 directory has macros in that are used for building the configure script. see #337 on the process of automated tarballs, https://github.com/Mightyjo/flex/releases/tag/v2.6.4-DUMMY seems to have the result with 2.6.4 (there is no INSTALL file in there but you should be fine with ... and yes, I still agree that it would be good to re-add the INSTALL file (possibly with new content) and if this is not done at least adjust the README.md which still references that file. |
The INSTALL file was previously provided by autotools. We treated it as a build product that only existed in the distribution tarball. Looks like the autotools project both stopped adding INSTALL to project directories and removed the test for its presence from 'make distcheck'. Need a new copy to commit, probably including a note about building maintainer sources with autogen.sh. Need to remove INSTALL from .gitignore at the point. Need to add INSTALL to EXTRA_DIST in Makefile.am. |
A note for myself: the default INSTALL file should be packaged with autoconf. Also, I shouldn't have blamed autotools for removing the behavior. We changed our "strictness" in configure.ac from gnu to foreign, as westes noted. Don't want to switch back to gnu because we don't follow all the conventions. |
I'll work up a pr shortly. Thank you, @Mightyjo. |
Since GNU autotools no longer provides a stock INSTALLATION file, we provide one that speaks to flex specifically. fixes #402
@Mightyjo. If you have thoughts on the content in INSTALL as #542 currently has it, I'd appreciate your comments. (I do intend it to be aimed at people familiar with building software as folk new to things probably are poorly served by starting with something so far down in the tolchain as flex is.) |
From the README (emphasis mine):
INSTALL
no longer seems to exist -- I downloaded the latest release,tar xzf
'd it, and inflex-2.6.4
, there's no file calledINSTALL
. There isn't even a file containingINSTALL
anywhere in its name. Has the file been renamed? Or is it just gone? Either way, the README should be updated.The text was updated successfully, but these errors were encountered: