From 8579155d90e1a91f9914c48bf0ebb103f5a8d4f2 Mon Sep 17 00:00:00 2001 From: Weston Ganger Date: Sat, 14 Oct 2023 13:06:57 -0700 Subject: [PATCH] Remove DB specific testing --- .github/workflows/test.yml | 116 ------------------------------------- README.md | 3 +- 2 files changed, 1 insertion(+), 118 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6e3ebfe..f272b64 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -16,8 +16,6 @@ jobs: matrix: include: ### TEST ALL RUBY VERSIONS, USE DEFAULT GEMFILE - - ruby: 2.3 - - ruby: 2.4 - ruby: 2.5 - ruby: 2.6 - ruby: 2.7 @@ -61,117 +59,3 @@ jobs: - name: Run tests run: | bundle exec rake - - - test_mysql: - runs-on: ubuntu-20.04 - services: - mysql: - image: mariadb - env: - MYSQL_ROOT_PASSWORD: password - MYSQL_DATABASE: test - options: --health-cmd="mysqladmin ping" --health-interval=10s --health-timeout=5s --health-retries=3 - ports: ['3306:3306'] - - strategy: - fail-fast: false - matrix: - include: - ### RAILS VERSION TESTING - ### DONT WORRY ABOUT TESTING ALL RUBY VERSIONS. THIS IS COVERED IN THE SQLITE3 TESTS - - ruby: 2.6 - env: - RAILS_VERSION: "5.0" - - ruby: 2.6 - env: - RAILS_VERSION: "5.1" - - ruby: 2.6 - env: - RAILS_VERSION: "5.2" - - ruby: 2.6 - env: - RAILS_VERSION: "6.0" - - ruby: 2.6 - env: - RAILS_VERSION: "6.1" - - ruby: "3.1" - env: - RAILS_VERSION: "7.0" - - env: - BUNDLE_GEMFILE: "${{ matrix.gemfile }}" - DB_GEM: "mysql2" - - steps: - - uses: actions/checkout@v3 - - - name: Install ruby - uses: ruby/setup-ruby@v1 - with: - ruby-version: "${{ matrix.ruby }}" - bundler-cache: true - - - name: Run tests - env: - DATABASE_URL: mysql2://root:password@127.0.0.1:3306/test - RAILS_ENV: test - run: | - bundle exec rake - - - test_pg: - runs-on: ubuntu-20.04 - services: - postgres: - image: postgres - env: - POSTGRES_USER: postgres - POSTGRES_PASSWORD: password - POSTGRES_DB: test - ports: ['5432:5432'] - - strategy: - fail-fast: false - matrix: - include: - ### RAILS VERSION TESTING - ### DONT WORRY ABOUT TESTING ALL RUBY VERSIONS. THIS IS COVERED IN THE SQLITE3 TESTS - - ruby: 2.6 - env: - RAILS_VERSION: "5.0" - - ruby: 2.6 - env: - RAILS_VERSION: "5.1" - - ruby: 2.6 - env: - RAILS_VERSION: "5.2" - - ruby: 2.6 - env: - RAILS_VERSION: "6.0" - - ruby: 2.6 - env: - RAILS_VERSION: "6.1" - - ruby: "3.1" - env: - RAILS_VERSION: "7.0" - - env: - BUNDLE_GEMFILE: "${{ matrix.gemfile }}" - DB_GEM: "pg" - - steps: - - uses: actions/checkout@v3 - - - name: Install ruby - uses: ruby/setup-ruby@v1 - with: - ruby-version: "${{ matrix.ruby }}" - bundler-cache: true - - - name: Run tests - env: - DATABASE_URL: postgres://postgres:password@localhost:5432/test - RAILS_ENV: test - run: | - bundle exec rake diff --git a/README.md b/README.md index 2cd7d18..7dc455f 100644 --- a/README.md +++ b/README.md @@ -154,11 +154,10 @@ Run server using: `bin/dev` or `cd test/dummy/; rails s` bundle exec rspec ``` -We can locally test different versions of Rails using `ENV['RAILS_VERSION']` and different database gems using `ENV['DB_GEM']` +We can locally test different versions of Rails using `ENV['RAILS_VERSION']` ``` export RAILS_VERSION=7.0 -export DB_GEM=sqlite3 bundle install bundle exec rspec ```