From 66754080b9dabfcd6c03a1d43eba9d717ff5be8b Mon Sep 17 00:00:00 2001
From: Simon Templer <simon@wetransform.to>
Date: Wed, 6 Apr 2022 00:35:48 +0200
Subject: [PATCH] fix: prevent failing conversion from GML to GPKG

...when GML IDs are not present in the source data.

ING-1747
---
 scripts/ogr-convert.sh | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/scripts/ogr-convert.sh b/scripts/ogr-convert.sh
index 0047b9e..d77de5f 100644
--- a/scripts/ogr-convert.sh
+++ b/scripts/ogr-convert.sh
@@ -113,6 +113,12 @@ if [ -n "$custom_args" ]; then
 elif [ "$target_format" == "GML" ]; then
   # special options for GML target format
   convert_cmd="$convert_cmd -dsco FORMAT=GML3.2 -dsco SRSNAME_FORMAT=OGC_URL -dsco PREFIX=hc -dsco TARGET_NAMESPACE=http://wetransform.to/hale-connect/converter/gml"
+elif [ "$target_format" == "GPKG" ]; then
+  # special options for GPKG target format
+
+  # -forceNullable: allow creation w/o GML IDs when converted from GML
+  # not added as a general option because for instance not supported by all drivers (e.g. GMLAS driver)
+  convert_cmd="$convert_cmd -forceNullable"
 fi
 
 # run