feat: add open option FORCE_SRS_DETECTION in case of gml files and if… #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had tough time with docker to test the functionality throughly but tested positive cases and it worked as expected. Command echoed to console from the script that generated |
kapil-agnihotri
force-pushed
the
feat-add-open-option-FORCE_SRS_DETECTION-in-case-of-gml-files-and-if-source_srs-is-not-set
branch
from
da0d49c to
644572b
Compare
stempler
approved these changes
Oct 28, 2024
stempler
reviewed
Oct 28, 2024
scripts/ogr-convert.sh
Outdated
| driverShortName=$(ogrinfo -json $source_loc | jq -r '.driverShortName') | ||
| echo "Driver Short Name: $driverShortName" | ||
| # Check if driverShortName is GML and source_srs is not set | ||
| if [ "$driverShortName" == "GML" ] && [ -z "$source_srs" ]; then |
There was a problem hiding this comment.
&& [ -z "$source_srs" ] seems redundant because we are already in the else case.
… source_srs is not set ING-4473
kapil-agnihotri
force-pushed
the
feat-add-open-option-FORCE_SRS_DETECTION-in-case-of-gml-files-and-if-source_srs-is-not-set
branch
from
644572b to
3769a5e
Compare
kapil-agnihotri
deleted the
feat-add-open-option-FORCE_SRS_DETECTION-in-case-of-gml-files-and-if-source_srs-is-not-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… source_srs is not set
ING-4473