Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: wrong behavior comment in parseUnits #2378

Closed
janndriessen opened this issue Jun 8, 2024 · 2 comments
Closed

minor: wrong behavior comment in parseUnits #2378

janndriessen opened this issue Jun 8, 2024 · 2 comments
Labels
A: Docs Area: Documentation

Comments

@janndriessen
Copy link

What is the type of issue?

Documentation is incorrect

What is the issue?

The comment at line https://github.com/wevm/viem/blob/main/src/utils/unit/parseUnits.ts#L22 says: // trim leading zeros.

but it should actually be // trim trailing zeros.

Where did you find it?

https://github.com/wevm/viem/blob/main/src/utils/unit/parseUnits.ts#L22

@janndriessen janndriessen added the A: Docs Area: Documentation label Jun 8, 2024
@jxom
Copy link
Member

jxom commented Jun 9, 2024

ty

@jxom jxom closed this as completed Jun 9, 2024
Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Viem version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A: Docs Area: Documentation
Projects
None yet
Development

No branches or pull requests

2 participants