Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashBytecode errors with const hex = hex_.replace('0x', ''); TypeError: hex_.replace is not a function #2695

Closed
1 task done
jarrodwatts opened this issue Sep 6, 2024 · 6 comments
Labels
needs reproduction Misc: Needs Reproduction

Comments

@jarrodwatts
Copy link

Check existing issues

Viem Version

2.21.2

Current Behavior

I have a big ACCOUNT_BYTECODE variable (too big to fit in the issue)

  • Call hashBytecode(ACCOUNT_BYTECODE)
  • Errors with the error below.
const hex = hex_.replace('0x', '');
                     ^
TypeError: hex_.replace is not a function
    at padHex
    at encodeBytes

Expected Behavior

No response

Steps To Reproduce

No response

Link to Minimal Reproducible Example

No response

Anything else?

No response

@jxom
Copy link
Member

jxom commented Sep 6, 2024

Minimal reproduction?

@jxom
Copy link
Member

jxom commented Sep 6, 2024

Your stacktrace has usage from encodeAbiParameters (encodeBytes). However, hashBytecode has no codepaths to encodeAbiParameters. Are you sure your stacktrace is coming from hashBytecode?

@jxom jxom added the needs reproduction Misc: Needs Reproduction label Sep 6, 2024
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Hello @jarrodwatts.

Please provide a minimal reproduction using StackBlitz, TypeScript Playground (for type issues), or a separate minimal GitHub repository.

Minimal reproductions are required as they save us a lot of time reproducing your config/environment and issue, and allow us to help you faster.

Once a minimal reproduction is added, a team member will confirm it works, then re-open the issue.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2024
@jarrodwatts
Copy link
Author

Hey @jxom - apologies was AFK for a few days.

You're right the hashBytecode works as expected. I was trying to provide the bytecode hash as an argument to my factory contract when calling deployContract. To fix the issue I was having, I just needed to wrap the hash inside toHex for it to work.

Not sure if any action is required here but just letting you know.

@jarrodwatts
Copy link
Author

Copy link
Contributor

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest Viem version. If you have any questions or comments you can create a new discussion thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs reproduction Misc: Needs Reproduction
Projects
None yet
Development

No branches or pull requests

2 participants