in non-local domain, "move pane" instead clones the pane

[neogeographica]

What Operating System(s) are you seeing this problem on?

Linux X11, macOS

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

20240812-215703-30345b36

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

The "Move a pane into its own window" action in the Launcher, when used on a pane in an ssh or unix domain, leaves linked copies of the pane in its original window and in the newly spawned window.

(If using the "local" domain this problem doesn't happen.)

On quitting and restarting wezterm, and reattaching to the domain, the pane will appropriately now be gone from that original window -- only present in the new window.

To Reproduce

Note that I reproduced this on Linux and macOS with stable version 20240203-110809-5046fc22. On macOS I then also reproduced it on nightly build version 20240812-215703-30345b36; haven't tried the nightly on Linux.

Working with a non-local domain (ssh or unix):

• Right-click on the "+" button to open the Launcher.
• Select "Move a pane into its own window."
• Pick a pane in that non-local domain.

The selected pane will indeed appear in a newly spawned window. However it will also remain in the original window. The pane in the original window and the pane in the new window act as "clones"... any typing or output in one is reflected in the other.

If I now do this:

• Quit wezterm.
• Restart wezterm.
• Reattach to the above domain.

Then I see that the pane is now gone from the original window, and is only present in the new window.

Configuration

Reproduced using this minimal config:

local wezterm = require 'wezterm'

local config = wezterm.config_builder()

config.ssh_domains = {
  {
    name = 'pylon',
    remote_address = 'pylon',
    username = 'joel',
  }
}
config.unix_domains = {
  {
    name = 'local-persistent',
  },
}

return config

Expected Behavior

"Move a pane into its own window" should not leave the pane in the original window.

Logs

Debug Overlay
wezterm version: 20240203-110809-5046fc22 aarch64-apple-darwin
Window Environment: macOS 13.6.3 (22G436)
Lua Version: Lua 5.4
WebGPU: name=Apple M2 Pro, device_type=IntegratedGpu, backend=Metal, vendor=0, device=0
Enter lua statements or expressions and hit Enter.
Press ESC or CTRL-D to exit

Anything else?

No response

[loops]

Hi neogeographica,

Would you be able to appply this PR, and test again: #5009

[neogeographica]

Thanks @loops ... I'm not currently compiling from source though. Will put that on the queue if I have a free Saturday afternoon or something. :-)

(I actually was kind of curious if that issue was related.)