Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling when submitting exercises #756

Open
rolandgeider opened this issue Jul 3, 2023 · 1 comment
Open

Better error handling when submitting exercises #756

rolandgeider opened this issue Jul 3, 2023 · 1 comment
Assignees
@rolandgeider
Labels
good first issue Good for newcomers

Comments

@rolandgeider
Copy link
Member

At the moment it's possible that while submitting an exercise the translations don't get accepted. This leaves a dangling exercise in the database.

Also need to investigate why they don't get accepted

e.g.
image

image-1
@rolandgeider rolandgeider self-assigned this Jul 3, 2023
rolandgeider added a commit to wger-project/wger that referenced this issue Jul 18, 2023
@rolandgeider
The default query manager now returns all objects again
d846e77 
This was causing problems when users would submit new exercises, since the
new translations could not load the exercise

See also wger-project/react/issues/756
@rolandgeider
Copy link
Member Author

Note that while the specific problem that was causing this were incorrect query managers, we should still handle errors better here and inform the user if something didn't work as expected

@rolandgeider rolandgeider added the good first issue Good for newcomers label Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rolandgeider rolandgeider

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rolandgeider