Skip to content
This repository has been archived by the owner on Jul 25, 2022. It is now read-only.

Fix worker #1935

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Fix worker #1935

wants to merge 6 commits into from

Conversation

johnsonw
Copy link
Contributor

@johnsonw johnsonw commented May 29, 2020 •
edited by jgrund
Loading

  • Fixes #1860.
  • Fixes #1858.
  • Fixes #1859.

This change is Reviewable

@johnsonw johnsonw added the bug label May 29, 2020
@johnsonw johnsonw added this to the IML EX V2 milestone May 29, 2020
@johnsonw johnsonw self-assigned this May 29, 2020
@johnsonw johnsonw marked this pull request as draft May 29, 2020 20:48
@johnsonw johnsonw force-pushed the fix-worker branch 2 times, most recently from 462a3d6 to 65f2434 Compare May 29, 2020 22:05
Base automatically changed from one-step-deployment to master June 1, 2020 14:17
@johnsonw johnsonw force-pushed the fix-worker branch 2 times, most recently from d4d56b6 to 344e812 Compare June 4, 2020 15:28
@johnsonw johnsonw marked this pull request as ready for review June 4, 2020 17:16
jgrund
jgrund suggested changes Jun 4, 2020
View reviewed changes
Copy link
Member

@jgrund jgrund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of changes from #1931 have been changed; those need to stay as they were

chroma_core/services/job_scheduler/job_scheduler.py Outdated Show resolved Hide resolved
chroma_core/services/job_scheduler/job_scheduler.py Outdated Show resolved Hide resolved
chroma_core/services/job_scheduler/job_scheduler_client.py Outdated Show resolved Hide resolved
chroma_core/services/lustre_audit/update_scan.py Outdated Show resolved Hide resolved
@johnsonw johnsonw force-pushed the fix-worker branch 9 times, most recently from c4bad3f to d67423b Compare June 10, 2020 14:27
@jgrund jgrund self-requested a review June 10, 2020 20:19
@johnsonw johnsonw force-pushed the fix-worker branch 4 times, most recently from 7990c4d to 5da635d Compare June 15, 2020 20:05
johnsonw added 3 commits June 16, 2020 15:29
@johnsonw
Updates to fix adding and removing a worker client node in both
54621bb 
monitored and managed mode.

Fixes #1860.
Fixes #1858.
Fixes #1859.

Signed-off-by: johnsonw <[email protected]>
@johnsonw
- Revert change in stratagem.py; this will be done in a separate patch
bf72ff4 
- Fix unit tests

Signed-off-by: johnsonw <[email protected]>
@johnsonw
- remove skip_if_satisfied from the stateful object
c804505 
Signed-off-by: johnsonw <[email protected]>
johnsonw and others added 2 commits June 16, 2020 15:29
@johnsonw
After discussions we've decided to restore the resource manager to its
dc1b91d 
prior functionality for the current release and rely on most clients
using the monitored worker profile.
- Revert resource manager change
- Update profile in integration tests
- Remove skip_if_satisfied logic from job_scheduler

Signed-off-by: johnsonw <[email protected]>
@johnsonw johnsonw requested a review from jgrund June 17, 2020 13:27
@jgrund jgrund modified the milestones: IML EX V2, IML EX V3 Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jgrund jgrund Awaiting requested review from jgrund

At least 2 approving reviews are required to merge this pull request.

Assignees

@johnsonw johnsonw

Labels
bug
Projects
None yet
Milestone
IML EX V3
3 participants
@johnsonw @jgrund @utopiabound