Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds cosign without signature #2

Open
DenisCarriere opened this issue Sep 10, 2023 · 4 comments
Open

Adds cosign without signature #2

DenisCarriere opened this issue Sep 10, 2023 · 4 comments

Comments

@DenisCarriere
Copy link

DenisCarriere commented Sep 10, 2023

When using cleos plugin + cosign transaction plugin, the action payload will cause a conflict since it doesn't contain the cosigner signature.

@aaroncox any thoughts on this?

cleos -u https://eos.greymass.com push transaction '{
    "expiration": "2023-09-10T03:53:44",
    "ref_block_num": 22818,
    "ref_block_prefix": 1891587786,
    "max_net_usage_words": 0,
    "max_cpu_usage_ms": 0,
    "delay_sec": 0,
    "context_free_actions": [],
    "actions": [
        {
            "account": "cpu.pomelo",
            "name": "noop",
            "authorization": [
                {
                    "actor": "cpu.pomelo",
                    "permission": "cosign"
                }
            ],
            "data": {}
        },
        {
            "account": "play.pomelo",
            "name": "transfer",
            "authorization": [
                {
                    "actor": "denis.gm",
                    "permission": "active"
                }
            ],
            "data": {
                "from": "denis.gm",
                "to": "d.w.pomelo",
                "quantity": "10.5000 PLAY",
                "memo": "234f441ecbb1"
            }
        }
    ],
    "transaction_extensions": []
}'
@aaroncox
Copy link
Member

I'm not sure you can actually append additional signatures when using the cleos push transaction call 🤔

I dug through the documentation and didn't see any mention of it. Are you aware of any way we could add that additional signature to the payload for cleos?

If there is none, maybe this is a good feature request for cleos development.

@DenisCarriere
Copy link
Author

I'm not aware of any "append signature"

Yes it would be a good feature to include

For now I guess it's fine, the user can remove the cosign action by manually editing

Unless there's a way to ignore cosigner for only cleos plugin

@aaroncox
Copy link
Member

There's not currently a way, but that's a good flag to potentially have on a wallet plugin.

Added an issue for tracking here: wharfkit/session#76

@DenisCarriere
Copy link
Author

Perfect! 👍 will be useful

@david-at-greymass david-at-greymass moved this to Icebox in Wharf v1.0 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Icebox
Development

No branches or pull requests

2 participants