From d4f5924d140017aa066d2c251f0fce3b9585b1e1 Mon Sep 17 00:00:00 2001 From: Rahul Singh Date: Wed, 18 Dec 2024 15:20:18 -0800 Subject: [PATCH 1/3] Update non-normative section for removeEntry() --- index.bs | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/index.bs b/index.bs index 881fb19..d4b13a2 100644 --- a/index.bs +++ b/index.bs @@ -979,15 +979,17 @@ The getDirectoryHandle(|name|, |option [=FileSystemHandle/locator=] contains a file named |name|, or an empty directory named |name|, this will attempt to delete that file or directory. - Attempting to delete a file or directory that does not exist is considered success, - while attempting to delete a non-empty directory will result in a promise rejection. + Attempting to delete a file or directory that does not exist will result in a promise + rejection with a "NotFoundError" DOMException. While attempting to delete a non-empty + directory will result in a promise rejection with an "InvalidModificationError" DOMException. : await |directoryHandle| . {{FileSystemDirectoryHandle/removeEntry()|removeEntry}}(|name|, { {{FileSystemRemoveOptions/recursive}}: true }) :: Removes the [=/file system entry=] named |name| in the [=directory entry=] [=locate an entry|locatable=] by |directoryHandle|'s [=FileSystemHandle/locator=]. If that entry is a directory, its contents will also be deleted recursively. - Attempting to delete a file or directory that does not exist is considered success. + Attempting to delete a file or directory that does not exist will result in a promise + rejection with a "NotFoundError" DOMException.
@@ -1758,6 +1760,7 @@ Marcos Cáceres, Martin Thomson, Olivier Yiptong, Philip Jägenstedt, +Rahul Singh, Randell Jesup, Richard Stotz, Ruth John, From c406d2107f1bd3dc2357b26a2432bce1bced638b Mon Sep 17 00:00:00 2001 From: Rahul Singh Date: Wed, 18 Dec 2024 15:59:36 -0800 Subject: [PATCH 2/3] Avoid using 'will' in updated text --- index.bs | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/index.bs b/index.bs index d4b13a2..e61e3ed 100644 --- a/index.bs +++ b/index.bs @@ -979,17 +979,18 @@ The getDirectoryHandle(|name|, |option [=FileSystemHandle/locator=] contains a file named |name|, or an empty directory named |name|, this will attempt to delete that file or directory. - Attempting to delete a file or directory that does not exist will result in a promise - rejection with a "NotFoundError" DOMException. While attempting to delete a non-empty - directory will result in a promise rejection with an "InvalidModificationError" DOMException. + Attempting to delete a file or directory that does not exist results in a promise + being rejected with a "NotFoundError" DOMException. Similarly, attempting to delete + a non-empty directory results in a promise being rejected with an + "InvalidModificationError" DOMException. : await |directoryHandle| . {{FileSystemDirectoryHandle/removeEntry()|removeEntry}}(|name|, { {{FileSystemRemoveOptions/recursive}}: true }) :: Removes the [=/file system entry=] named |name| in the [=directory entry=] [=locate an entry|locatable=] by |directoryHandle|'s [=FileSystemHandle/locator=]. If that entry is a directory, its contents will also be deleted recursively. - Attempting to delete a file or directory that does not exist will result in a promise - rejection with a "NotFoundError" DOMException. + Attempting to delete a file or directory that does not exist results in a promise + being rejected with a "NotFoundError" DOMException.
From 068f1e2eccbcaacb608a352a3bb3ee2f1236f8fd Mon Sep 17 00:00:00 2001 From: Rahul Singh Date: Wed, 18 Dec 2024 16:18:53 -0800 Subject: [PATCH 3/3] One more update --- index.bs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/index.bs b/index.bs index e61e3ed..be45713 100644 --- a/index.bs +++ b/index.bs @@ -980,9 +980,9 @@ The getDirectoryHandle(|name|, |option directory named |name|, this will attempt to delete that file or directory. Attempting to delete a file or directory that does not exist results in a promise - being rejected with a "NotFoundError" DOMException. Similarly, attempting to delete - a non-empty directory results in a promise being rejected with an - "InvalidModificationError" DOMException. + being rejected with a "NotFoundError" DOMException. Attempting to delete a non-empty + directory results in a promise being rejected with an "InvalidModificationError" + DOMException. : await |directoryHandle| . {{FileSystemDirectoryHandle/removeEntry()|removeEntry}}(|name|, { {{FileSystemRemoveOptions/recursive}}: true }) :: Removes the [=/file system entry=] named |name| in the [=directory entry=]