Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing step in parse a vint #167

Open
simonwuelker opened this issue Apr 15, 2023 · 0 comments
Open

Confusing step in parse a vint #167

simonwuelker opened this issue Apr 15, 2023 · 0 comments

Comments

@simonwuelker
Copy link

simonwuelker commented Apr 15, 2023

Related to #93.
Steps 5 and 6 in the algorithm are

5. Let index be 0. 
6. Let parsed number be sequence[index] & ~mask. 

This seems like a mistake, since the first four bytes of sequence have already been compared to static values at the beginning of the matches the signature for WebM algorithm (which is the only caller of parse a vint) and therefore can't contain data that we would need to parse.

Would I be correct in assuming that index should initially be equal to iter instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants
@simonwuelker and others