From df9d1928efa6c16836d8dd8ec719e97b9afb3a9f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Frederik=20=E2=80=9CFreso=E2=80=9D=20S=2E=20Olesen?= Date: Mon, 6 Mar 2017 11:51:32 +0100 Subject: [PATCH] Remove notes related to GStreamer flacparse Thomas had assembled some notes related to GStreamer 0.10's flacparse. See commits 862221c5fdbacad3b2676409dcb2281441d8f070 and 29ac4d49b616b172a14cc5b425449ff008cb4520. However, since GStreamer is being removed entirely[*], these notes are not really relevant for current development/status of whipper. So let's get rid of them. [*] https://github.com/JoeLametta/whipper/pull/67 and https://github.com/JoeLametta/whipper/pull/121 and https://github.com/JoeLametta/whipper/pull/130 --- doc/hacking/bugs/bgo-650785/bgo-650785.otl | 19 ------ doc/hacking/bugs/bgo-650785/bisect.sh | 10 --- .../bugs/bgo-650785/flacparse-testcase.c | 64 ------------------- doc/hacking/flacparse.otl | 24 ------- 4 files changed, 117 deletions(-) delete mode 100644 doc/hacking/bugs/bgo-650785/bgo-650785.otl delete mode 100755 doc/hacking/bugs/bgo-650785/bisect.sh delete mode 100644 doc/hacking/bugs/bgo-650785/flacparse-testcase.c delete mode 100644 doc/hacking/flacparse.otl diff --git a/doc/hacking/bugs/bgo-650785/bgo-650785.otl b/doc/hacking/bugs/bgo-650785/bgo-650785.otl deleted file mode 100644 index b5a98bfd..00000000 --- a/doc/hacking/bugs/bgo-650785/bgo-650785.otl +++ /dev/null @@ -1,19 +0,0 @@ -bugzilla 650785 - bisecting -good - notes - using teuf's C test case, but fixing the spaces between quotes and ! - tested on F17 ana - commits - e0cadab - teuf fails - 8823ae251a72bd18fc93322914c70390fc16c6b3 - slomo's patch from bz report - teuf works - 8229709 - 1 patch after 0.10.30 - teuf works - a53540346a18d27b94f5254ac2582cb844e9bde0 - tim's fix for bugzilla 650785 - commit a53540346a18d27b94f5254ac2582cb844e9bde0 - Author: Tim-Philipp Müller - Date: Mon May 23 13:50:46 2011 +0100 diff --git a/doc/hacking/bugs/bgo-650785/bisect.sh b/doc/hacking/bugs/bgo-650785/bisect.sh deleted file mode 100755 index 8e6f9f27..00000000 --- a/doc/hacking/bugs/bgo-650785/bisect.sh +++ /dev/null @@ -1,10 +0,0 @@ -GOOD=/home/thomas/gst/git/gst-plugins-good/gst/audioparsers -MORI=/home/thomas/dev/own/morituri - -cd $GOOD -make - -GST_PLUGIN_PATH=$GOOD gst-inspect flacparse | grep ersion: - -cd $MORI -GST_PLUGIN_PATH=$GOOD ./flacparse-testcase $MORI/morituri/test/track.flac diff --git a/doc/hacking/bugs/bgo-650785/flacparse-testcase.c b/doc/hacking/bugs/bgo-650785/flacparse-testcase.c deleted file mode 100644 index 4d90940d..00000000 --- a/doc/hacking/bugs/bgo-650785/flacparse-testcase.c +++ /dev/null @@ -1,64 +0,0 @@ -/* gcc -Wall $(pkg-config --cflags --libs gstreamer-0.10) -g3 -ggdb3 -o flacparse-testcase ./flacparse-testcase.c */ -#include - -static const char PIPELINE[] = "filesrc location=%s " \ - "! decodebin ! audio/x-raw-int " \ - "! appsink name=sink sync=False " \ - "emit-signals=True"; - -int main(int argc, char **argv) -{ - GstElement *pipeline; - GstElement *sink; - gchar *pipeline_str; - GstStateChangeReturn state_change_status; - gint64 duration; - GstFormat query_format; - gboolean query_success; - - gst_init(&argc, &argv); - - if (argc != 2) { - g_print("Usage: %s filename\n", argv[0]); - return 1; - } - - pipeline_str = g_strdup_printf(PIPELINE, argv[1]); - pipeline = gst_parse_launch(pipeline_str, NULL); - if (pipeline == NULL) { - g_print("Failed to create pipeline\n"); - g_print("%s\n", pipeline_str); - return 2; - } - g_free(pipeline_str); - - gst_element_set_state(pipeline, GST_STATE_PAUSED); - state_change_status = gst_element_get_state(pipeline, NULL, NULL, - GST_CLOCK_TIME_NONE); - if (state_change_status != GST_STATE_CHANGE_SUCCESS) { - g_print("Failed to set pipeline to PAUSED\n"); - return 3; - } - - sink = gst_bin_get_by_name(GST_BIN(pipeline), "sink"); - if (sink == NULL) { - g_print("Couldn't find sink in pipeline\n"); - return 4; - } - - query_format = GST_FORMAT_DEFAULT; - query_success = gst_element_query_duration(sink, &query_format, - &duration); - if (query_success) { - g_print("%s duration is %"G_GINT64_FORMAT"\n", argv[1], duration); - return 0; - } else { - g_print("Couldn't get duration for %s\n", argv[1]); - return 5; - } - - gst_object_unref(GST_OBJECT(sink)); - gst_object_unref(GST_OBJECT(pipeline)); - - return 6; -} diff --git a/doc/hacking/flacparse.otl b/doc/hacking/flacparse.otl deleted file mode 100644 index 58a4c2cf..00000000 --- a/doc/hacking/flacparse.otl +++ /dev/null @@ -1,24 +0,0 @@ -audioparsersbad in -bad 0.10.20 - has flacparse - has rank 0 - no problem -audioparsers in good 0.10.29 (when it was released for first time) - fails - fedora 15 -Break - autoplug rank change - 952b27 Mon Aug 16 2010 - first bad after: 0.10.20 (but presumed innocent, f14) - first bad with the change: 0.10.21 (see release notes) - moved out of bad in 0.10.22 to good 0.10.29 -Fix - 8823ae/1183d0/a53540 mon may 23 2011 - target milestone good 0.10.31 -Conclusion - bad versions - -bad - after 0.10.20 - until 0.10.22 (ok) - -good - from 0.10.29 - until 0.10.31 (next release)