Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Private methods in default actions make overriding harder #4

Open
sampart opened this issue Dec 19, 2013 · 0 comments
Open

Private methods in default actions make overriding harder #4

sampart opened this issue Dec 19, 2013 · 0 comments

Comments

@sampart
Copy link
Collaborator

sampart commented Dec 19, 2013

Many of the actions in Action, in particular ListAction.php have a number of private methods. This means that, if you want to override one of them and make a custom action, you have to copy-and-paste the private methods out of the parent class.

If those methods were simply protected, this problem would disappear.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sampart