Skip to content
This repository has been archived by the owner on Nov 14, 2018. It is now read-only.

Added action dependency after all actions have been cleaned initially. #51

Merged
merged 1 commit into from
Nov 20, 2012

Conversation

richsage
Copy link
Contributor

This was discovered after discovering issue #50. If I have the following code:

public function configure()
{
    // ...
    $this->addActions(array(
        new BatchActionCollection(),
        new ListAction(),
    ));
}

then the initialisation of the BatchActionCollection will fail as it can't find the list action required (as the List action hasn't been initialized yet). This commit moves the dependency check to after the first pass over the raw actions, so that all actions are present in the array, before running the check.

@teo-sk
Copy link

teo-sk commented Nov 18, 2011

+1, please merge :)

richsage added a commit that referenced this pull request Nov 20, 2012
Added action dependency after all actions have been cleaned initially.
@richsage richsage merged commit 81676c5 into whiteoctober:master Nov 20, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants