Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for FCS3.2 #27

Open
JcGKitten opened this issue Feb 5, 2024 · 2 comments
Open

Support for FCS3.2 #27

JcGKitten opened this issue Feb 5, 2024 · 2 comments

Comments

@JcGKitten
Copy link
Contributor

Hey @whitews,
there is the new FCS3.2 standard which has some new keywords, especially
the PnDATATYPE. This allows single columns to have another datatype then the one set in DATATYPE keyword. See 3.3.41 on page 41. Do you already have plans to support that? It might be a problem cause the values in the used array must be of the same type as I understand it.

I will also think about a solution but wanted to check in with you first.

Best wishes
Max

@whitews
Copy link
Owner

whitews commented Feb 5, 2024

Hey Max,

Yes, I've known about the new 3.2 version and read through the spec doc. Agreed, the mixed datatype will require an overhaul to the FlowIO code. The issue is I haven't been able to find any example 3.2 files. I think there's only 1 BD cytometer that exports these files, but could be wrong about that. In any case, we need one or more example files, specifically ones that are public & showcase the new features so we can add them to the repo with test cases. Ideally, it would be nice if they weren't ginormous. Do you have access to any that you can share?

Regards,
Scott

@JcGKitten
Copy link
Contributor Author

Hey Scott,
I got a few files from a BD S8 cytometer, but I have to check back if they can be made public and I'm not sure if they showcase all the new stuff. Also they have some values, like range limits, which seem very odd to me. I let you know if I can provide some samples. Thanks for letting me know that you are aware of the new standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants