You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for this great tool.
I'm loading one side and I disable the difference calculation. I only enable the difference calculation after loading the second text, because it does not make sense to show the difference between a text and an empty one.
There is only a small problem, because if the user tries to scroll down the first text, before loading the second one, there is a Javascript error.
I fixed it (just a hack), in _scrolling, by adding:
if (!this.hasOwnProperty('changes')) return;
before the cycle where the property changes is used.
If this hack makes sense, I can submit a pull request.
The text was updated successfully, but these errors were encountered:
On 13 February 2015 at 00:31, Jorge Gustavo Rocha [email protected]
wrote:
Hi,
Thanks for this great tool.
I'm loading one side and I disable the difference calculation. I only
enable the difference calculation after loading the second text, because it
does not make sense to show the difference between a text and an empty one.
There is only a small problem, because if the user tries to scroll down
the first text, before loading the second one, there is a Javascript error.
I fixed it (just a hack), in _scrolling, by adding:
if (!this.hasOwnProperty('changes')) return;
before the cycle where the property changes is used.
If this hack makes sense, I can submit a pull request.
—
Reply to this email directly or view it on GitHub #20.
Hi,
Thanks for this great tool.
I'm loading one side and I disable the difference calculation. I only enable the difference calculation after loading the second text, because it does not make sense to show the difference between a text and an empty one.
There is only a small problem, because if the user tries to scroll down the first text, before loading the second one, there is a Javascript error.
I fixed it (just a hack), in
_scrolling
, by adding:before the cycle where the property
changes
is used.If this hack makes sense, I can submit a pull request.
The text was updated successfully, but these errors were encountered: